-
Notifications
You must be signed in to change notification settings - Fork 535
docs: add installation guide clarifying Hub vs pip index for environments #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,6 +136,11 @@ def ta_to_hf(self) -> tuple[Dataset, Dataset | None]: | |
| eval_dataset_rows = [] | ||
| _, user_prompt = self.ta_env.get_observation() | ||
| words = self.ta_env.word_list | ||
| # Handle both list and dict word_list formats | ||
| # Dict format (e.g. TwentyQuestions-v0): {category: [words]} | ||
| # List format (e.g. Wordle-v0): [words] | ||
| if isinstance(words, dict): | ||
| words = [word for category_words in words.values() for word in category_words] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dict word_list fix enables silent correctness bug for non-Wordle gamesMedium Severity The new dict Additional Locations (1)Reviewed by Cursor Bugbot for commit fec3ead. Configure here. |
||
| # set seed | ||
| random.seed(self.seed) | ||
| for i in range(self.num_train_examples + self.num_eval_examples): | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hub vs pip guidance missing from docs/faqs.md
Low Severity
This PR addresses user confusion from issue #1100 about pip index availability, which is notable FAQ-worthy information. The Hub vs pip installation distinction is only documented in
environments/README.mdbut not indocs/faqs.md, where users commonly look for such clarifications. The project rule states that notable information available for reference that doesn't neatly map to a specific documentation section belongs indocs/faqs.md.Triggered by project rule: BugBot Instructions
Reviewed by Cursor Bugbot for commit fec3ead. Configure here.