Useful skills and perks - #187
Draft
ahmed007boss wants to merge 21 commits into
Draft
Conversation
ahmed007boss
marked this pull request as draft
April 17, 2024 23:21
added 18 commits
April 18, 2024 02:03
- fix bug where PerkBonus can be infinity - fix exception when GetAllPartyHeros mobileParty parameter is null
- add better Steward Giving Hands perk - make item quality side by side with tier affect gained exp from item donation - fix few bugs
- add proper BKConstructionModel.GetBoostAmount Perk Effect - family members now include grandchildren and nephew and nieces - Steward Relocation and AidCorps perks
- make WarriorsDiet apply on either leader or quartermaster - Steward Gourmet and Sound Reserves perks
- filter perks calculation with only active heros - restructure perk data - add steward skill effect - add ForcedLabor and Contractors perks
- add MasterOfPlanning,MasterOfWarcraft and PriceOfLoyalty traits
- add Medicine Perks data - add SelfMedication Perk
- add bonus from court and royal court - add TriageTent and WalkItOff perks - fix few bugs
- fix few perk related texts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the impact of perks when the feature is turned on from the settings, enabling perks to increase in power as related character skill level improves. Also, expand the range of roles for each skill to offer more flexibility.
Example:
Steward
Medicine (in progress)
Leadership
OneHanded
TwoHanded
Polearm
Bow
Crossbow
Throwing
Riding
Athletics
Crafting
Tactics
Scouting
Roguery
Charm
Trade
Engineering
Scholarship
Theology
Lordship