Support Pi camera launch in Docker containers#1130
Conversation
Summary of ChangesHello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Raspberry Pi cameras within the TurtleBot3 Docker environments for both ROS Humble and Jazzy distributions. By integrating Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for using the Raspberry Pi camera within the Docker containers for Humble and Jazzy distributions. The changes primarily involve adding necessary system and ROS dependencies, and building libcamera from source inside the Dockerfiles. My review focuses on optimizing the Dockerfiles by reducing the number of layers, cleaning up build artifacts to decrease image size, and making the library path configuration more robust. These improvements will lead to more efficient and portable Docker images.
There was a problem hiding this comment.
Pull request overview
This PR adds Raspberry Pi camera support to TurtleBot3 Docker containers by installing the required dependencies and libcamera library. The changes enable users to launch and use Pi cameras directly from within Docker containers.
- Version bumped from 2.3.4 to 2.3.5 across all TurtleBot3 packages
- Added libcamera v0.5.2 and camera-ros dependencies to both Humble and Jazzy Docker images
- Added
/run/udevvolume mount for device detection in docker-compose files
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_teleop/setup.py | Version bump to 2.3.5 |
| turtlebot3_teleop/package.xml | Version bump to 2.3.5 |
| turtlebot3_teleop/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_node/package.xml | Version bump to 2.3.5 |
| turtlebot3_node/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_navigation2/package.xml | Version bump to 2.3.5 |
| turtlebot3_navigation2/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_example/setup.py | Version bump to 2.3.5 |
| turtlebot3_example/package.xml | Version bump to 2.3.5 |
| turtlebot3_example/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_description/package.xml | Version bump to 2.3.5 |
| turtlebot3_description/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_cartographer/package.xml | Version bump to 2.3.5 |
| turtlebot3_cartographer/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3_bringup/package.xml | Version bump to 2.3.5 |
| turtlebot3_bringup/CHANGELOG.rst | Added 2.3.5 changelog entry with no changes noted |
| turtlebot3/package.xml | Version bump to 2.3.5 |
| turtlebot3/CHANGELOG.rst | Added 2.3.5 changelog entry documenting Pi Camera Docker support |
| docker/jazzy/docker-compose.yml | Added /run/udev volume mount for device detection |
| docker/jazzy/Dockerfile | Added camera-ros, urdf, libcamera dependencies and build instructions |
| docker/humble/docker-compose.yml | Added /run/udev volume mount for device detection |
| docker/humble/Dockerfile | Added camera-ros, urdf, libcamera dependencies and build instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Added the required dependency for Pi camera support in the Docker container.
Users now only need to enter the container and launch the camera to use the Pi camera.
Test
E-manual PR : ROBOTIS-GIT/emanual#1832