Pass ROCm package index URL through JAX release workflow#65
Open
erman-gurses wants to merge 6 commits into
Open
Pass ROCm package index URL through JAX release workflow#65erman-gurses wants to merge 6 commits into
erman-gurses wants to merge 6 commits into
Conversation
ScottTodd
reviewed
Jun 24, 2026
Comment on lines
+21
to
+24
| rocm_package_find_links_url: | ||
| description: "ROCm package index / find-links URL for the JAX manylinux build." | ||
| type: string | ||
| default: "https://rocm.devreleases.amd.com/whl-multi-arch/" |
Member
There was a problem hiding this comment.
As mentioned at ROCm/TheRock#6054 (comment), this default URL is not compatible with --find-links. Should be clear on what index type the workflows need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related PR: ROCm/TheRock#6054
Add
rocm_package_find_links_urlto the rockrel JAX release workflow and forward it to the reusable TheRock JAX build workflow.This allows the JAX manylinux build path to consume ROCm packages from a configurable package index instead of relying on a hardcoded URL.
Changes
Add
rocm_package_find_links_urlworkflow input tomulti_arch_release_linux_jax_wheels.ymlForward
rocm_package_find_links_urlto the reusablemulti_arch_build_linux_jax_wheels.ymlworkflowDefault the value to the current dev multi-arch package index:
https://rocm.devreleases.amd.com/whl-multi-arch/Motivation
The JAX manylinux build flow now installs ROCm packages from a package index. Passing the package source as an input allows the workflow to support different release channels (dev, nightly, prerelease) without hardcoding a specific index URL in the build workflow.
Tests:
https://github.com/ROCm/rockrel/actions/runs/28086158341