Skip to content

Pass ROCm package index URL through JAX release workflow #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erman-gurses wants to merge 7 commits into
base: main
Choose a base branch
from
+10 −5
Open

Pass ROCm package index URL through JAX release workflow #65

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a778a8
Pass ROCm package index URL through JAX release workflow
erman-gurses Jun 24, 2026
f956fc1
Add rocm_package_index_url and remove rocm_package_find_links_url
erman-gurses Jun 24, 2026
5fd785c
Add quotes for descriptions
erman-gurses Jun 24, 2026
8f1e97d
Add branch for test
erman-gurses Jun 24, 2026
0a1ea93
Pass rocm_package_index_url
erman-gurses Jun 24, 2026
cafadf9
Test
erman-gurses Jun 25, 2026
aa90a57
Test
erman-gurses Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/multi_arch_release_linux_jax_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ on:
description: ROCm package version to build against.
type: string
required: true
rocm_package_find_links_url:
description: "ROCm package index / find-links URL for the JAX manylinux build."
type: string
default: "https://rocm.devreleases.amd.com/whl-multi-arch/"

@ScottTodd ScottTodd Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned at ROCm/TheRock#6054 (comment), this default URL is not compatible with --find-links. Should be clear on what index type the workflows need.

tar_url:
description: URL to the shared TheRock tarball used for the build.
type: string
Expand Down Expand Up @@ -45,6 +49,7 @@ jobs:
test_amdgpu_family: ${{ inputs.test_amdgpu_family }}
release_type: ${{ inputs.release_type }}
rocm_version: ${{ inputs.rocm_version }}
rocm_package_find_links_url: ${{ inputs.rocm_package_find_links_url }}
tar_url: ${{ inputs.tar_url }}
repository: ${{ inputs.repository || 'ROCm/TheRock' }}
ref: ${{ inputs.ref || '' }}
Loading