fix: update renamed store-suggestions function calls missed in refactor - #718
fix: update renamed store-suggestions function calls missed in refactor#718HetCreep wants to merge 1 commit into
Conversation
The approved-verbs refactor renamed DisableStoreSearchSuggestionsForAllUsers / EnableStoreSearchSuggestionsForAllUsers to Set-StoreSearchSuggestionsDisabledForAllUsers / Set-StoreSearchSuggestionsEnabledForAllUsers, but the two call sites in Invoke-Changes.ps1 still used the old names, so applying or undoing DisableStoreSearchSuggestions on the all-users path failed with 'The term ... is not recognized'. The test suite did not catch this because its BeforeAll stubs also defined the OLD names, masking the dangling calls. Update the call sites, the test stubs/mocks/assertions to the new names, and the two stale .EXAMPLE doc lines. Fixes Raphire#717
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Sysprep all-users Store search suggestions apply and undo paths now call renamed ChangesStore search suggestion helper rename
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Heya, This was actually already fixed in #710, I just wasn't able to merge it in until now. Thanks for taking the time to fix it though. |
The approved-verbs refactor (#708) renamed the store-suggestions all-users functions to Set-StoreSearchSuggestionsDisabledForAllUsers / Set-StoreSearchSuggestionsEnabledForAllUsers, but the two call sites in Invoke-Changes.ps1 (the Sysprep apply path and the all-users undo path) still call the OLD names -- so that path now dies with 'The term DisableStoreSearchSuggestionsForAllUsers is not recognized', exactly as reported in #717. Notably the Pester suite did not catch this because Tests/Invoke-Changes.Tests.ps1's BeforeAll stubs also defined the old names, which masked the dangling calls -- the suite passed while the production path was broken. This PR updates: the two call sites in Invoke-Changes.ps1, the test stubs/mocks/assertions to the new names (so the suite now exercises the real contract), and two stale .EXAMPLE doc lines in Set-StoreSearchSuggestions.ps1. Verification: parse-clean on all three files; grep confirms zero references to the old names remain anywhere in Scripts/ or Tests/. I could not run the Pester suite locally (in-box Pester 3.4; the suite needs v5 and I avoid installing tools on this machine) -- tests.yml should exercise it here. Fixes #717
Summary by CodeRabbit