Skip to content

Remove moveit_task_constructor_* and rviz_marker_tools additional recipes (now via ros2-gbp) - #243

Open
iamnambiar wants to merge 1 commit into
RoboStack:mainfrom
iamnambiar:remove-mtc-additional-recipe
Open

Remove moveit_task_constructor_* and rviz_marker_tools additional recipes (now via ros2-gbp)#243
iamnambiar wants to merge 1 commit into
RoboStack:mainfrom
iamnambiar:remove-mtc-additional-recipe

Conversation

@iamnambiar

Copy link
Copy Markdown
Contributor

This PR removes the manual mtc* and rviz_marker_tools overrides from rosdistro_additional_recipes.yaml, which pointed to an unofficial third-party release fork. This repo has two conflicting sources for the same packages. Because additional_recipes.yaml takes precedence over snapshot.yaml, the build was silently stuck on the old, unofficial, stale repo instead of using the newer official release.

This PR simply deletes the now-redundant override so the build falls through to the official source.

@traversaro

Copy link
Copy Markdown
Member

Because additional_recipes.yaml takes precedence over snapshot.yaml, the build was silently stuck on the old, unofficial, stale repo instead of using the newer official release.

Thanks for noticing! This probably suggest that this conflict should result in an error in case of conflict, I opened RoboStack/vinca#126 to track this.

@traversaro

Copy link
Copy Markdown
Member

The tricky aspect is this is effectively changing the ABI of some packages that install headers and shared libraries, and typically we do not that without a full rebuild, as the ros2-distro-mutex is the only way to ensure ABI Compatibility (at least until we work on RoboStack/vinca#96).

@iamnambiar

Copy link
Copy Markdown
Contributor Author

so, what do you think is the best way to proceed here? should this PR wait until the full rebuild?

@traversaro

Copy link
Copy Markdown
Member

so, what do you think is the best way to proceed here? should this PR wait until the full rebuild?

Yes, I am afraid so. Buy a full rebuild can be opened by any contributor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants