use BLoC event transformer to ignore new confirmations while one is processing - #1701
Merged
Merged
Conversation
…rocessing already
ethicnology
reviewed
Dec 24, 2025
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "0.9.22+7" | ||
| version: "0.9.22+8" |
Member
There was a problem hiding this comment.
I hope this build change doesnt fuck us like last time 🤣
Contributor
Author
There was a problem hiding this comment.
Oh, is this something I should reverse maybe? I just did a make setup to start clean and it probably updated this automatically.
Contributor
Author
There was a problem hiding this comment.
Or fix it on a specific version that we know works? @ethicnology
Member
There was a problem hiding this comment.
In theory it shouldn't be dangerous, but I don't know if you remember once this camera package fucked us on a build bump.
No worries we should check if camera still works after
ethicnology
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the bloc_concurrency package to solve this with a "quick" but definitive fix. This doesn't mean we shouldn't solve the underlying cause of the state variable being used wrongly in the confirmation event handler anymore, but using the bloc_concurrency package here and in other BLoCs is a great first line of defense to avoid concurrency issues even if the underlying code isn't concurrency safe yet.