Skip to content

use BLoC event transformer to ignore new confirmations while one is processing #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i5hi merged 1 commit into from
Dec 30, 2025
Merged

use BLoC event transformer to ignore new confirmations while one is processing #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/features/sell/presentation/bloc/sell_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import 'package:bb_mobile/features/send/domain/usecases/prepare_liquid_send_usec
import 'package:bb_mobile/features/send/domain/usecases/sign_bitcoin_tx_usecase.dart';
import 'package:bb_mobile/features/send/domain/usecases/sign_liquid_tx_usecase.dart';
import 'package:bip21_uri/bip21_uri.dart';
import 'package:bloc_concurrency/bloc_concurrency.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:freezed_annotation/freezed_annotation.dart';

Expand Down Expand Up @@ -90,7 +91,10 @@ class SellBloc extends Bloc<SellEvent, SellState> {
on<SellWalletSelected>(_onWalletSelected);
on<SellExternalWalletNetworkSelected>(_onExternalWalletNetworkSelected);
on<SellOrderRefreshTimePassed>(_onOrderRefreshTimePassed);
on<SellSendPaymentConfirmed>(_onSendPaymentConfirmed);
on<SellSendPaymentConfirmed>(
_onSendPaymentConfirmed,
transformer: droppable(), // Prevent multiple simultaneous confirmations
);
on<SellPollOrderStatus>(_onPollOrderStatus);
on<SellReplaceByFeeChanged>(_onReplaceByFeeChanged);
on<SellUtxosSelected>(_onUtxosSelected);
Expand Down
12 changes: 10 additions & 2 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,14 @@ packages:
url: "https://pub.dev"
source: hosted
version: "9.1.0"
bloc_concurrency:
dependency: "direct main"
description:
name: bloc_concurrency
sha256: "86b7b17a0a78f77fca0d7c030632b59b593b22acea2d96972588f40d4ef53a94"
url: "https://pub.dev"
source: hosted
version: "0.3.0"
blockchain_utils:
dependency: transitive
description:
Expand Down Expand Up @@ -306,10 +314,10 @@ packages:
dependency: transitive
description:
name: camera_avfoundation
sha256: "0efb057a1fecdbf9b697272fbf79afbd47ac0e7bd69b4d900d3f304b31d93bad"
sha256: "087a9fadef20325cb246b4c13344a3ce8e408acfc3e0c665ebff0ec3144d7163"
url: "https://pub.dev"
source: hosted
version: "0.9.22+7"
version: "0.9.22+8"

@ethicnology ethicnology Dec 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this build change doesnt fuck us like last time 🤣

@kumulynja kumulynja Dec 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is this something I should reverse maybe? I just did a make setup to start clean and it probably updated this automatically.

@kumulynja kumulynja Dec 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or fix it on a specific version that we know works? @ethicnology

@ethicnology ethicnology Dec 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory it shouldn't be dangerous, but I don't know if you remember once this camera package fucked us on a build bump.

No worries we should check if camera still works after

camera_platform_interface:
dependency: transitive
description:
Expand Down
1 change: 1 addition & 0 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ dependencies:
path: ^1.9.1
http: ^1.6.0
lints: ^6.0.0
bloc_concurrency: ^0.3.0

dev_dependencies:
build_runner: ^2.10.4
Expand Down