chore: clean up swaps - #2290
Conversation
|
Claude finished @i5hi's task in 3m 58s —— View job PR Review: chore: clean up swapsI reviewed the diff against
🔴 Blocking — three new files are referenced but not committedThe PR adds imports/usages for three files that do not exist in the branch (
This looks like a missed 🟡 Minor / worth a look1. Fee floor can be undone by the "half the amount" cap — final withFloor = _absoluteWithFloor(live, txSize: txSize, isLiquid: isLiquid);
if (amountSat != null && amountSat > 0) {
return min(withFloor, max(1, amountSat ~/ 2));
}
2. amountSat: isMaxSend
? null
: swap.paymentAmount,These don't match 3. Leftover 4. ✅ Things that look correct
I did not run |
|
Note: production flavor is commented out for local ios simulator development. It must be removed before merging. |
|
Note: debug logs must be cleaned before merging |
…her teardown, and send-flow fee fixes (preserve lockup fee, tx-fee fallback, confirm-amount flash)
…N details use shimmer during load. Text update for Amount in receive for LN. Minor fixes in confirmation screen details - align invoice and add copy button for swap id
Swap rework: reliable status tracking, claims/refunds, and live fees
Reworks the swaps feature end-to-end to fix unreliable Boltz status updates and failing claims/refunds, and to make persisted fees reflect what was actually paid on-chain. Only includes logic improvements - no fundamental architectural changes.
All swap types need to be tested before merging.