fix: derive alert action from publicPolicy for public tokens#537
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
…cPolicy Use the client-side publicPolicy map as the source of truth for alert actions when reshaping artifacts for public token users, instead of trusting the server-assigned alert.action field. This ensures deterministic, policy-consistent results regardless of server behavior.
Contributor
Author
|
Note: PR #538 ( |
11 tasks
Bill Li (billxinli)
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicPolicymap as source of truth for alert actions inreshapeArtifactForPublicPolicy, instead of trusting the server-assignedalert.actionfieldactionis now derived client-side viapublicPolicy.get(alert.type), ensuring deterministic results regardless of server behavioractionfield in the output (e.g.,malware → 'error',criticalCVE → 'warn')Test plan
test/unit/http-client.test.mts— action filtering and alert compaction tests use realpublicPolicyalert typestest/unit/reshape-artifact-public-policy.test.mts— all tests use real alert types (malware,criticalCVE,deprecated) and verify derivedactionfieldundefined, alert still passes through)