[BugFix] Python inline UDF creation failing when file='inline' is omitted#72359
Conversation
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14708fc4ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-4.1 |
✅ Backports have been createdDetails
Cherry-pick of 697ec65 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
…tted (StarRocks#72359) Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
Why I'm doing:
When creating an inline Starrocks Python UDF using the AS $$ ... $$ syntax, the documentation states that file='inline' is optional. However, omitting it causes the following error at creation time - inline function file should be 'inline'
What I'm doing:
StringUtils.equalsIgnoreCase(null, "inline") returns false, so when file is omitted (objectFile == null) and UDF creation failing with
inline function file should be 'inline'Using default value as 'inline as per documentation'.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: