Skip to content

[BugFix] Python inline UDF creation failing when file='inline' is omitted (backport #72359)#72412

Merged
wanpengfei-git merged 2 commits into
branch-4.1from
mergify/bp/branch-4.1/pr-72359
May 5, 2026
Merged

[BugFix] Python inline UDF creation failing when file='inline' is omitted (backport #72359)#72412
wanpengfei-git merged 2 commits into
branch-4.1from
mergify/bp/branch-4.1/pr-72359

Conversation

@mergify

@mergify mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

When creating an inline Starrocks Python UDF using the AS $$ ... $$ syntax, the documentation states that file='inline' is optional. However, omitting it causes the following error at creation time - inline function file should be 'inline'

What I'm doing:

StringUtils.equalsIgnoreCase(null, "inline") returns false, so when file is omitted (objectFile == null) and UDF creation failing with inline function file should be 'inline'

Using default value as 'inline as per documentation'.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

This is an automatic backport of pull request #72359 done by [Mergify](https://mergify.com).

…tted (#72359)

(cherry picked from commit 697ec65)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateFunctionStmtAnalyzerTest.java
@mergify mergify Bot added the conflicts label Apr 30, 2026
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 697ec65 has failed:

On branch mergify/bp/branch-4.1/pr-72359
Your branch is up to date with 'origin/branch-4.1'.

You are currently cherry-picking commit 697ec65fd4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateFunctionAnalyzer.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateFunctionStmtAnalyzerTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@stdpain stdpain reopened this Apr 30, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 30, 2026 15:14
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
@wanpengfei-git wanpengfei-git merged commit 10420ad into branch-4.1 May 5, 2026
27 of 28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-4.1/pr-72359 branch May 5, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants