Skip to content

[BugFix] Python inline UDF creation failing when file='inline' is omitted (backport #72359) #72412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanpengfei-git merged 2 commits into from
May 5, 2026
Merged

[BugFix] Python inline UDF creation failing when file='inline' is omitted (backport #72359) #72412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ecf1cd
[BugFix] Python inline UDF creation failing when file='inline' is omi…
s4ch1n Apr 30, 2026
99a8e36
Update CreateFunctionStmtAnalyzerTest.java
stdpain Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateFunctionAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,14 +609,11 @@ private void analyzePython(CreateFunctionStmt stmt, ConnectContext context) {
}
String symbol = properties.get(CreateFunctionStmt.SYMBOL_KEY);
String inputType = properties.getOrDefault(CreateFunctionStmt.INPUT_TYPE, "scalar");
String objectFile = stmt.getProperties().get(CreateFunctionStmt.FILE_KEY);
String objectFile = properties.getOrDefault(CreateFunctionStmt.FILE_KEY, "inline");

if (isInline && !StringUtils.equalsIgnoreCase(objectFile, "inline")) {
ErrorReport.reportSemanticException(ErrorCode.ERR_COMMON_ERROR, "inline function file should be 'inline'");
}
if (isInline) {
objectFile = "inline";
}

if (!inputType.equalsIgnoreCase("arrow") && !inputType.equalsIgnoreCase("scalar")) {
ErrorReport.reportSemanticException(ErrorCode.ERR_COMMON_ERROR, "unknown input type:" + inputType);
Expand Down
14 changes: 14 additions & 0 deletions fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateFunctionStmtAnalyzerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,20 @@ private CreateFunctionStmt createPyStmt(String symbol, String type, String targe
createFunctionSql, 32).get(0);
}

private CreateFunctionStmt createPyInlineStmtNoFile(String symbol) {
Config.enable_udf = true;
String createFunctionSql = String.format("CREATE FUNCTION ABC.MY_UDF_JSON_GET_NOFILE(string, string) \n"
+ "RETURNS string \n"
+ "type = 'Python'\n"
+ "symbol = '%s'\n"
+ "AS $$\n"
+ "def a(b):\n"
+ " return b\n"
+ "$$;", symbol);
return (CreateFunctionStmt) com.starrocks.sql.parser.SqlParser.parse(
createFunctionSql, 32).get(0);
}

@Test
public void testJUDF() {
assertThrows(Throwable.class, () -> {
Expand Down
Loading