[Refactor] Remove IVM FULL refresh mode#72288
Conversation
Per the IMV V1 PRD, user-visible refresh modes are limited to INCREMENTAL and PCT; FULL is removed. FULL has not been released, so no compatibility shim is needed. - Drop FULL from MaterializedView.RefreshMode enum and isFull() helper - Drop the FULL branch from MVRefreshProcessorFactory.newProcessor - Reword the IVM schema-change error to "drop and re-create the MV" since the legacy "trigger a full refresh" path no longer exists - Update affected unit tests and remove the iceberg_full SQL test - Drop the FULL bullet from CREATE MATERIALIZED VIEW docs (en/zh/ja) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8ed138988
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🌎 Translation Required?✅ All translation files are up to date.
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@mergify backport branch-4.1 |
✅ Backports have been createdDetails
Cherry-pick of 0056da9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@mergify backport branch-4.1 |
✅ Backports have been createdDetails
Cherry-pick of 0056da9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 0056da9)
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Why I'm doing:
What I'm doing:
user-visible refresh modes are limited to INCREMENTAL and PCT; FULL is removed. FULL has not been released, so no compatibility shim is needed.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: