Skip to content

[Refactor] Remove IVM FULL refresh mode (backport #72288)#72321

Merged
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72288
Apr 29, 2026
Merged

[Refactor] Remove IVM FULL refresh mode (backport #72288)#72321
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72288

Conversation

@mergify

@mergify mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

user-visible refresh modes are limited to INCREMENTAL and PCT; FULL is removed. FULL has not been released, so no compatibility shim is needed.

  • Drop FULL from MaterializedView.RefreshMode enum and isFull() helper
  • Drop the FULL branch from MVRefreshProcessorFactory.newProcessor
  • Reword the IVM schema-change error to "drop and re-create the MV" since the legacy "trigger a full refresh" path no longer exists
  • Update affected unit tests and remove the iceberg_full SQL test
  • Drop the FULL bullet from CREATE MATERIALIZED VIEW docs (en/zh/ja)

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

This is an automatic backport of pull request #72288 done by [Mergify](https://mergify.com).

@mergify mergify Bot added the conflicts label Apr 29, 2026
@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 0056da9 has failed:

On branch mergify/bp/branch-4.1/pr-72288
Your branch is up to date with 'origin/branch-4.1'.

You are currently cherry-picking commit 0056da9f39.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   docs/ja/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   docs/zh/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java
	modified:   fe/fe-core/src/test/java/com/starrocks/alter/AlterMVJobExecutorEditLogTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/alter/AlterMaterializedViewTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/scheduler/mv/ivm/IVMBasedMvRefreshProcessorIcebergTest.java
	deleted:    test/sql/test_materialized_view_ivm/R/test_ivm_with_iceberg_full
	deleted:    test/sql/test_materialized_view_ivm/T/test_ivm_with_iceberg_full

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVRefreshProcessorFactory.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions Bot added documentation Documentation changes automerge labels Apr 29, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 05:56
@mergify mergify Bot mentioned this pull request Apr 29, 2026
24 tasks
@mergify mergify Bot closed this Apr 29, 2026
auto-merge was automatically disabled April 29, 2026 05:56

Pull request was closed

@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@Youngwb Youngwb reopened this Apr 29, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 06:53
@Youngwb Youngwb closed this Apr 29, 2026
auto-merge was automatically disabled April 29, 2026 08:03

Pull request was closed

@Youngwb Youngwb reopened this Apr 29, 2026
@Youngwb

Youngwb commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@mergify rebase

@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

rebase

❌ Base branch update has failed

Details

PullRequest::RebaseConflictError

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 08:05
@Youngwb

Youngwb commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

auto-merge was automatically disabled April 29, 2026 08:13

Head branch was pushed to by a user without write access

Copilot AI commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved. The cherry-pick had unresolved conflict markers in MVRefreshProcessorFactory.java. Fixed in commit 16aa96d by removing the markers and using the renamed processor class names (MVHybridRefreshProcessor, MVIVMRefreshProcessor, MVPCTRefreshProcessor) consistent with the rename commit already in branch-4.1.

Copilot AI requested a review from Youngwb April 29, 2026 08:15
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
(cherry picked from commit 0056da9)
@Youngwb Youngwb force-pushed the mergify/bp/branch-4.1/pr-72288 branch from 16aa96d to d109222 Compare April 29, 2026 08:29
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 08:29
@github-actions

Copy link
Copy Markdown
Contributor

🌎 Translation Required?

All translation files are up to date.
Great job! No translation actions are required for this PR.

🕒 Last updated: Wed, 29 Apr 2026 08:35:32 GMT

@wanpengfei-git wanpengfei-git merged commit fc3eeb5 into branch-4.1 Apr 29, 2026
31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-4.1/pr-72288 branch April 29, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants