Skip to content

[Enhancement] Reject FORCE refresh on INCREMENTAL/AUTO materialized views#72336

Merged
Astralidea merged 1 commit into
StarRocks:mainfrom
Youngwb:imv-v1/reject-force-on-incremental
Apr 30, 2026
Merged

[Enhancement] Reject FORCE refresh on INCREMENTAL/AUTO materialized views#72336
Astralidea merged 1 commit into
StarRocks:mainfrom
Youngwb:imv-v1/reject-force-on-incremental

Conversation

@Youngwb

@Youngwb Youngwb commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

the FORCE clause on REFRESH MATERIALIZED VIEW must be rejected for materialized views with refresh_mode=INCREMENTAL (and refresh_mode=AUTO, which shares the same code path via isIncrementalOrAuto()). FORCE is only meaningful for the legacy PCT mode where it triggers a full re-materialization; for incremental MVs the recovery path is drop-and-recreate.

Production:

  • MaterializedViewAnalyzer.visitRefreshMaterializedViewStatement: in the same block that already rejects partition-level refresh on INCREMENTAL/AUTO MVs, add a FORCE rejection with a clear error message that points users at the drop-and-recreate workflow.

Tests:

  • testIncrementalRefreshModeRejectsForceRefresh: create a PCT MV via the SQL path (no Iceberg dependency), flip the persisted refresh_mode to "incremental", then assert that REFRESH ... FORCE is rejected with the expected message.
  • testPctRefreshModeAllowsForceRefresh: regression guard that PCT MVs still accept the FORCE clause.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

…iews

Per the IMV V1 PRD, the FORCE clause on REFRESH MATERIALIZED VIEW must be
rejected for materialized views with refresh_mode=INCREMENTAL (and
refresh_mode=AUTO, which shares the same code path via
isIncrementalOrAuto()). FORCE is only meaningful for the legacy PCT
mode where it triggers a full re-materialization; for incremental MVs
the recovery path is drop-and-recreate.

Production:
- MaterializedViewAnalyzer.visitRefreshMaterializedViewStatement: in
  the same block that already rejects partition-level refresh on
  INCREMENTAL/AUTO MVs, add a FORCE rejection with a clear error
  message that points users at the drop-and-recreate workflow.

Tests:
- testIncrementalRefreshModeRejectsForceRefresh: create a PCT MV via
  the SQL path (no Iceberg dependency), flip the persisted
  refresh_mode to "incremental", then assert that
  REFRESH ... FORCE is rejected with the expected message.
- testPctRefreshModeAllowsForceRefresh: regression guard that PCT MVs
  still accept the FORCE clause.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
@Youngwb Youngwb requested a review from a team as a code owner April 29, 2026 08:14
@github-actions github-actions Bot added the 4.1 label Apr 29, 2026
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

Copy link
Copy Markdown
Contributor

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 4 4 100.00% []

@github-actions

Copy link
Copy Markdown
Contributor

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea merged commit 75a5d6e into StarRocks:main Apr 30, 2026
124 of 127 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-4.1

@github-actions github-actions Bot removed the 4.1 label Apr 30, 2026
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

backport branch-4.1

✅ Backports have been created

Details

Cherry-pick of 75a5d6e has failed:

On branch mergify/bp/branch-4.1/pr-72336
Your branch is up to date with 'origin/branch-4.1'.

You are currently cherry-picking commit 75a5d6e2c1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/analysis/RefreshMaterializedViewTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Youngwb Youngwb deleted the imv-v1/reject-force-on-incremental branch April 30, 2026 02:02
Youngwb added a commit that referenced this pull request Apr 30, 2026
…iews (#72336)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
(cherry picked from commit 75a5d6e)
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2026
…iews (backport #72336) (#72363)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Hyper-FF pushed a commit to Hyper-FF/starrocks that referenced this pull request Apr 30, 2026
…iews (StarRocks#72336)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
robd003 pushed a commit to robd003/starrocks that referenced this pull request May 6, 2026
…iews (StarRocks#72336)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants