Skip to content

[Enhancement] Reject FORCE refresh on INCREMENTAL/AUTO materialized views (backport #72336)#72363

Merged
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72336
Apr 30, 2026
Merged

[Enhancement] Reject FORCE refresh on INCREMENTAL/AUTO materialized views (backport #72336)#72363
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72336

Conversation

@mergify

@mergify mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

the FORCE clause on REFRESH MATERIALIZED VIEW must be rejected for materialized views with refresh_mode=INCREMENTAL (and refresh_mode=AUTO, which shares the same code path via isIncrementalOrAuto()). FORCE is only meaningful for the legacy PCT mode where it triggers a full re-materialization; for incremental MVs the recovery path is drop-and-recreate.

Production:

  • MaterializedViewAnalyzer.visitRefreshMaterializedViewStatement: in the same block that already rejects partition-level refresh on INCREMENTAL/AUTO MVs, add a FORCE rejection with a clear error message that points users at the drop-and-recreate workflow.

Tests:

  • testIncrementalRefreshModeRejectsForceRefresh: create a PCT MV via the SQL path (no Iceberg dependency), flip the persisted refresh_mode to "incremental", then assert that REFRESH ... FORCE is rejected with the expected message.
  • testPctRefreshModeAllowsForceRefresh: regression guard that PCT MVs still accept the FORCE clause.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

This is an automatic backport of pull request #72336 done by [Mergify](https://mergify.com).

@mergify mergify Bot added the conflicts label Apr 30, 2026
@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 75a5d6e has failed:

On branch mergify/bp/branch-4.1/pr-72336
Your branch is up to date with 'origin/branch-4.1'.

You are currently cherry-picking commit 75a5d6e2c1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/analysis/RefreshMaterializedViewTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 30, 2026 02:01
@mergify mergify Bot closed this Apr 30, 2026
auto-merge was automatically disabled April 30, 2026 02:01

Pull request was closed

@mergify

mergify Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@Youngwb Youngwb reopened this Apr 30, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 30, 2026 02:05
…iews (#72336)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
(cherry picked from commit 75a5d6e)
@Youngwb Youngwb force-pushed the mergify/bp/branch-4.1/pr-72336 branch from 964a00c to 1dc50f5 Compare April 30, 2026 02:08
@wanpengfei-git wanpengfei-git merged commit 81750b2 into branch-4.1 Apr 30, 2026
27 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-4.1/pr-72336 branch April 30, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants