Skip to content

[Enhancement] Improve error messages for large column capacity limit checks#76303

Merged
kevincai merged 1 commit into
StarRocks:mainfrom
cccaarr:improve-large-column-capacity-error-msg
Jul 14, 2026
Merged

[Enhancement] Improve error messages for large column capacity limit checks#76303
kevincai merged 1 commit into
StarRocks:mainfrom
cccaarr:improve-large-column-capacity-error-msg

Conversation

@cccaarr

@cccaarr cccaarr commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

When the large-column capacity checker trips, the error returned to the client
embedded internal diagnostics — the driver's raw pointer (addr=this) and the
full operator chain from to_readable_string(). That is internal debugging
information that should not reach end users, and it gives them nothing
actionable. Separately, the shared status string for CAPACITY_LIMIT_EXCEED
had a typo ("Capaticy").

What I'm doing:

  1. Fix the typo Capaticy -> Capacity in the shared status string
    (code_as_string), which is the common prefix for all
    CapacityLimitExceed results.
  2. In the pipeline driver's large-column checker, keep the detailed diagnostics
    (operator index/name, query id, driver address, full operator chain) in
    be.WARNING for operators/developers, and return a concise, actionable
    message to the client instead:
    Large column detected, please reduce rows per batch or the size of string/array values

No functional change — the guard still trips on the same condition; only the
user-visible message text and the destination of the internal diagnostics change.

Fixes #76302

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5

Signed-off-by: cccaarr <jiangxiaoyu@starrocks.com>
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@github-actions

Copy link
Copy Markdown
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

Copy link
Copy Markdown
Contributor

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kevincai
kevincai enabled auto-merge (squash) July 13, 2026 16:25
@github-actions

Copy link
Copy Markdown
Contributor

[BE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/base/status.cpp 1 1 100.00% []
🔵 be/src/exec/runtime/pipeline_driver.cpp 3 3 100.00% []

@kevincai
kevincai merged commit f991ac5 into StarRocks:main Jul 14, 2026
128 of 148 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-4.0

@github-actions

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-4.1

@github-actions

Copy link
Copy Markdown
Contributor

@Mergifyio backport branch-3.5

@github-actions github-actions Bot removed the 3.5 label Jul 14, 2026
@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

backport branch-4.0

✅ Backports have been created

Details

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

backport branch-4.1

✅ Backports have been created

Details

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

backport branch-3.5

✅ Backports have been created

Details

wanpengfei-git pushed a commit that referenced this pull request Jul 17, 2026
…s (backport #76303) (#76334)

Signed-off-by: cccaarr <jiangxiaoyu@starrocks.com>
Co-authored-by: cccaarr <jiangxiaoyu@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jul 17, 2026
…s (backport #76303) (#76336)

Signed-off-by: cccaarr <jiangxiaoyu@starrocks.com>
Co-authored-by: cccaarr <jiangxiaoyu@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Large-column capacity checker leaks internal diagnostics to the client

4 participants