[Enhancement] Improve error messages for large column capacity limit checks (backport #76303)#76336
Open
mergify[bot] wants to merge 1 commit into
Open
[Enhancement] Improve error messages for large column capacity limit checks (backport #76303)#76336mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When the large-column capacity checker trips, the error returned to the client
embedded internal diagnostics — the driver's raw pointer (
addr=this) and thefull operator chain from
to_readable_string(). That is internal debugginginformation that should not reach end users, and it gives them nothing
actionable. Separately, the shared status string for
CAPACITY_LIMIT_EXCEEDhad a typo ("Capaticy").
What I'm doing:
Capaticy->Capacityin the shared status string(
code_as_string), which is the common prefix for allCapacityLimitExceedresults.(operator index/name, query id, driver address, full operator chain) in
be.WARNINGfor operators/developers, and return a concise, actionablemessage to the client instead:
Large column detected, please reduce rows per batch or the size of string/array valuesNo functional change — the guard still trips on the same condition; only the
user-visible message text and the destination of the internal diagnostics change.
Fixes #76302
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #76303 done by [Mergify](https://mergify.com).