fix(forms): Fix checkbox export values and wide dropdown options - #7288
Merged
Frooodle merged 4 commits intoAug 29, 2026
Merged
Conversation
balazs-szucs
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
August 4, 2026 15:09
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the form-fill UI’s checkbox handling to better respect per-widget exportValue when determining checked state, and improves select/dropdown layout by forcing a full-width minimum size in the overlay.
Changes:
- Update checkbox checked-state logic in
FieldInputandFormFieldOverlayto compare againstexportValuewhen present. - Set overlay
<select>styling tominWidth: 100%to prevent narrow dropdown rendering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/editor/src/core/tools/formFill/FormFieldOverlay.tsx | Adjusts overlay checkbox checked-state logic to prefer exportValue; makes dropdowns consistently wide via minWidth: 100%. |
| frontend/editor/src/core/tools/formFill/FieldInput.tsx | Adjusts sidebar/field-list checkbox checked-state logic to prefer exportValue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frooodle
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improves the logic for handling checkbox fields in the making more accurate state determination based on the
exportValuepropertyChanges:
FieldInput.tsxandFormFieldOverlay.tsxto check if the value matches the widget'sexportValuewhen present, improving accuracy for custom checkbox values.minWidthof select elements to100%inFormFieldOverlay.tsxto ensure consistent layout and alignment.Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass