Skip to content

fix(forms): Fix checkbox export values and wide dropdown options - #7288

Merged
Frooodle merged 4 commits into
Stirling-Tools:mainfrom
balazs-szucs:fix/form-field-checkbox-dropdown
Aug 29, 2026
Merged

fix(forms): Fix checkbox export values and wide dropdown options#7288
Frooodle merged 4 commits into
Stirling-Tools:mainfrom
balazs-szucs:fix/form-field-checkbox-dropdown

Conversation

@balazs-szucs

Copy link
Copy Markdown
Collaborator

Description of Changes

Improves the logic for handling checkbox fields in the making more accurate state determination based on the exportValue property

Changes:

  • Updated checkbox checked state logic in both FieldInput.tsx and FormFieldOverlay.tsx to check if the value matches the widget's exportValue when present, improving accuracy for custom checkbox values.
  • Set the minWidth of select elements to 100% in FormFieldOverlay.tsx to ensure consistent layout and alignment.

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have run task check to verify linters, typechecks, and tests pass
  • I have tested my changes locally. Refer to the Testing Guide for more details.

Copilot AI review requested due to automatic review settings August 4, 2026 15:09
@dosubot dosubot Bot added size:S This PR changes 10-29 lines ignoring generated files. Bugfix Pull requests that fix bugs labels Aug 4, 2026
@stirlingbot stirlingbot Bot added the Front End Issues or pull requests related to front-end development label Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the form-fill UI’s checkbox handling to better respect per-widget exportValue when determining checked state, and improves select/dropdown layout by forcing a full-width minimum size in the overlay.

Changes:

  • Update checkbox checked-state logic in FieldInput and FormFieldOverlay to compare against exportValue when present.
  • Set overlay <select> styling to minWidth: 100% to prevent narrow dropdown rendering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
frontend/editor/src/core/tools/formFill/FormFieldOverlay.tsx Adjusts overlay checkbox checked-state logic to prefer exportValue; makes dropdowns consistently wide via minWidth: 100%.
frontend/editor/src/core/tools/formFill/FieldInput.tsx Adjusts sidebar/field-list checkbox checked-state logic to prefer exportValue.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/editor/src/core/tools/formFill/FieldInput.tsx
Comment thread frontend/editor/src/core/tools/formFill/FormFieldOverlay.tsx
@Frooodle
Frooodle requested a review from a team as a code owner August 29, 2026 21:29
@Frooodle
Frooodle merged commit 74be5bf into Stirling-Tools:main Aug 29, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Pull requests that fix bugs Front End Issues or pull requests related to front-end development size:S This PR changes 10-29 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants