Skip to content

fix(forms): Fix checkbox export values and wide dropdown options #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frooodle merged 4 commits into from
Aug 29, 2026
+12 −6
Merged

fix(forms): Fix checkbox export values and wide dropdown options #7288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13c864d
fix checkbox export values and wide dropdown options
balazs-szucs Aug 2, 2026
4cf3ced
fix: update checkbox export value handling to support custom values a…
balazs-szucs Aug 4, 2026
e5813a6
Merge branch 'main' into fix/form-field-checkbox-dropdown
balazs-szucs Aug 4, 2026
9e29de1
Merge branch 'main' into fix/form-field-checkbox-dropdown
Frooodle Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frontend/editor/src/core/tools/formFill/FieldInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ function FieldInputInner({
);

case "checkbox": {
const isChecked = !!value && value !== "Off";
const onValue = (field.widgets && field.widgets[0]?.exportValue) || "Yes";
const exportVal = field.widgets && field.widgets[0]?.exportValue;
const isChecked = exportVal
? value === exportVal || value === "Yes"
: !!value && value !== "Off";
const onValue = exportVal || "Yes";
return (
<Checkbox
size="xs"
Expand Down
9 changes: 6 additions & 3 deletions frontend/editor/src/core/tools/formFill/FormFieldOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,11 @@ function WidgetInputInner({
);

case "checkbox": {
// Checkbox is checked when value is anything other than 'Off' or empty
const isChecked = !!value && value !== "Off";
// When toggling on, use the widget's exportValue (e.g. 'Red', 'Blue') or fall back to 'Yes'
// Checkbox is checked when value matches exportValue if present, or is non-empty and not 'Off'
const isChecked = widget.exportValue
? value === widget.exportValue || value === "Yes"
: !!value && value !== "Off";
// When toggling on, use the widget's exportValue (e.g. 'Red', 'Blue', 'Pass') or fall back to 'Yes'
const onValue = widget.exportValue || "Yes";
return (
<div
Expand Down Expand Up @@ -433,6 +435,7 @@ function WidgetInputInner({
multiple={field.multiSelect}
style={{
...inputBaseStyle,
minWidth: "100%",
padding: 0,
paddingLeft: 2,
appearance: "auto",
Expand Down
2 changes: 1 addition & 1 deletion frontend/editor/src/core/tools/formFill/providers/PdfiumFormProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function toFormField(
// Derive value string
let value = f.value;
if (type === "checkbox") {
value = f.isChecked ? "Yes" : "Off";
value = f.isChecked ? f.widgets[0]?.exportValue || "Yes" : "Off";
} else if (type === "radio") {
// Use widget index as the canonical radio value.
// This avoids issues with duplicate exportValues across widgets
Expand Down
Loading