Skip to content

Add GitHub Actions workflow to test NPM package installation#254

Merged
geourjoa merged 23 commits intomainfrom
251-ci-check
Apr 15, 2026
Merged

Add GitHub Actions workflow to test NPM package installation#254
geourjoa merged 23 commits intomainfrom
251-ci-check

Conversation

@geourjoa
Copy link
Copy Markdown
Contributor

@geourjoa geourjoa commented Apr 14, 2026

Check if there is an issue when installing Mirador and MAE through npm

@geourjoa
Copy link
Copy Markdown
Contributor Author

@paulhectork Can you check this one ?

@paulhectork
Copy link
Copy Markdown
Collaborator

it works ! tested by setting

  • peerDependencies.@mui/system: "^5" => fails (as expected)
  • peerDependencies.@mui/system: ">=7.x" => works (as expected)

i also removed my proposed github action since it's redundant (and less good) than yours. thanks !!

@geourjoa
Copy link
Copy Markdown
Contributor Author

it works ! tested by setting

* `peerDependencies.@mui/system: "^5"` => fails (as expected)

* `peerDependencies.@mui/system: ">=7.x"` => works (as expected)

i also removed my proposed github action since it's redundant (and less good) than yours. thanks !!

Great, thank you for the test. I Merge

@geourjoa geourjoa merged commit 0731ddd into main Apr 15, 2026
3 checks passed
@geourjoa geourjoa deleted the 251-ci-check branch April 15, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants