revert: add response-only metadata fields to image elements and blocks (#57) - #58
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
slack-block-kit-validator | eca2a74 | Commit Preview URL Branch Preview URL |
Jul 01 2026, 05:56 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #57 per request. Removes the response-only image metadata fields that #57 added to the
image_blockandimage_elementschema$defs:image_width,image_height,image_bytes,is_animated(block only), andfallback.Note: #57 was merged but never released — the tree is still
0.1.10, because that PR's squash subject lacked a Conventional Commits prefix and release-please never cut a version. So no published package ever shipped these fields; this simply backs the change out ofmain.Type of change
src/slack-block-kit.schema.json) — revertChanges
src/slack-block-kit.schema.json:image_block/image_elementback to their pre-Add response-only metadata fields to image elements and blocks #57 property sets (drops the 5 / 4 response-only fields).src/types.generated.tsfrom the schema (removes the corresponding optional properties).test/blocks.test.ts,test/block-elements.test.ts).Testing
pnpm testpasses (493 tests)pnpm typecheckpassespnpm lintpassespnpm validate-schemapassesSchema changes
0.1.10schema; existing valid payloads still validate. (Trade-off: image blocks pulled straight from Slack's Web API responses will again report these response-only fields asunknown property.)Checklist
README.md(no README changes were made in Add response-only metadata fields to image elements and blocks #57)🤖 Generated with Claude Code
Generated by Claude Code