Allow medley for every song#1356
Draft
dgruss wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
i tried this for a few medleys, including duets, but maybe users with more medley experience should see whether this behaves as expected or what should still be improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I never really understood why medley mode was restricted to only some songs. From a user's perspective, that feels arbitrary: some songs can be selected for medleys, some don't and whether it can be part of a medley should not depend on whether USDX found a repeated refrain, whether the file is relative, whether it is a duet, or whether
#CALCMEDLEYhappens to be set, but only based on whether the user thinks this is a good choice of song for a medley.This also came up again in the discussion around #1345: medley availability and medley icons are problematic due to overlaps, now also due to missing analysis state, so the UI on which arbitrary songs can be selected is even less clear (fully unclear maybe).
This PR tries to resolve the problem by focusing on what the user wants: if the user wants a specific song in a medley, they shall have it.
The core is to make all medley paths follow the same unified logic that is more permissive:
#MEDLEYSTARTBEAT/#MEDLEYENDBEATis preferred (similar to preview start / end, these tags are used if available but they are not necessary to generate a preview)Trackvariable in thePlayer, see Duet Highscore #1004, we could allow all players in the medley to sing the same track or maybe randomize which player sings which track - to be decided then I guess)#CALCMEDLEYis ignored as a legacy switchWith this, the medley selection never fails. It might not be the greatest medley, but the players can choose whatever they like and the game will just do what the player wants, best effort.