Fix percentAgreement to prevent false consensus when subset of participants respond - #1012
Merged
Conversation
…lation Co-authored-by: JamesPHoughton <4304478+JamesPHoughton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] percentAgreement should not return true when all values are undefined
Fix percentAgreement to exclude undefined values from agreement calculation
Aug 25, 2025
|
Collaborator
|
There could be some unexpected behavior, actually, if one person has submitted, and the values are being computed and displayed before other participants (who will eventually submit) have a chance to do so. Can we think through the different edge cases here? It is possible that this will be used on the same page as the submission of the actual values. For example, if folks say "I'm ready to proceed" or "Not ready to proceed", if the initial values are all Undefined, and then one person submits "I'm ready to proceed" do we really want it to take that as consensus on proceeding? or should we just throw false when everything is undefined, but also include undefined responses in the denominator when looking for consensus? |
Deliberation
|
||||||||||||||||||||||||||||
| Project |
Deliberation
|
| Branch Review |
copilot/fix-754
|
| Run status |
|
| Run duration | 06m 39s |
| Commit |
|
| Committer | James Houghton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
16
|
| View all changes introduced in this branch ↗︎ | |
Collaborator
|
@copilot - can you make changes to account for the edge cases described above? |
…or for consensus calculation Co-authored-by: JamesPHoughton <4304478+JamesPHoughton@users.noreply.github.com>
Contributor
Author
I've addressed the edge case you identified. The fix changes the denominator calculation to use total participants instead of just responders, preventing false consensus when only a subset have responded. Key change in commit 724e17c:
This ensures that if only 1 out of 4 people responds "ready", it shows 25% agreement rather than 100%, preventing premature consensus triggers. The logic still returns false when all values are undefined (no responses yet). |
Copilot
AI
changed the title
Fix percentAgreement to exclude undefined values from agreement calculation
Fix percentAgreement to prevent false consensus when subset of participants respond
Aug 26, 2025
JamesPHoughton
approved these changes
Aug 27, 2025
JamesPHoughton
marked this pull request as ready for review
August 27, 2025 11:06
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
percentAgreementposition modifier was incorrectly calculating consensus percentages, leading to false consensus when only a subset of participants had responded.Problem
The original implementation had two issues:
For example, with 4 participants where only 1 says "ready":
This could trigger premature actions in scenarios like "ready to proceed" checks.
Solution
Modified the
percentAgreementlogic to:Behavior Changes
[undefined, undefined, "ready"]with ≥50% threshold →false(33% agreement, not 100%)[undefined, "ready", "ready"]with ≥50% threshold →true(67% agreement)[undefined, undefined, undefined]→false(no responses yet)["ready", "ready", "ready"]→ works exactly as beforeThis ensures
percentAgreementprovides accurate consensus measurements for real-time decision scenarios where participants may respond at different times.Fixes #754.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.