Skip to content

Fix percentAgreement to prevent false consensus when subset of participants respond #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPHoughton merged 4 commits into from
Aug 27, 2025
Merged

Fix percentAgreement to prevent false consensus when subset of participants respond #1012

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3454493
Initial plan
Copilot Aug 25, 2025
fa7f56a
Fix percentAgreement to exclude undefined values from agreement calcu…
Copilot Aug 25, 2025
724e17c
Fix percentAgreement edge case: include undefined values in denominat…
Copilot Aug 26, 2025
5c3be53
Merge branch 'main' into copilot/fix-754
JamesPHoughton Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions client/src/components/ConditionalRender.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,17 +122,26 @@ function RecursiveConditionalRender({ conditions, children }) {
let conditionMet = false;
if (position === "percentAgreement") {
const counts = {};
referenceValues.forEach((val) => {
const cleanValue =
typeof val === "string" ? val.toLowerCase().trim() : val;
counts[cleanValue] = (counts[cleanValue] || 0) + 1;
});
const maxCount = Math.max(...Object.values(counts));
conditionMet = compare(
(maxCount / referenceValues.length) * 100,
comparator,
value
);
const definedValues = referenceValues.filter(val => val !== undefined);

// If no defined values, no agreement is possible
if (definedValues.length === 0) {
conditionMet = false;
} else {
definedValues.forEach((val) => {
const cleanValue =
typeof val === "string" ? val.toLowerCase().trim() : val;
counts[cleanValue] = (counts[cleanValue] || 0) + 1;
});
const maxCount = Math.max(...Object.values(counts));
// Use total participants (referenceValues.length) as denominator
// to include undefined responses in the consensus calculation
conditionMet = compare(
(maxCount / referenceValues.length) * 100,
comparator,
value
);
}
} else if (position === "any") {
conditionMet = referenceValues.some((val) =>
compare(val, comparator, value)
Expand Down
Loading