Compose: Fully deprecate the 'pure' HoC#78674
Open
Mamaduka wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
[Package] Data
|
Size Change: +56 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #57173, which soft-deprecated the
pureHoC via JSDoc only.deprecated()warning whenwp.compose.pureis used.purewithReact.memo:withSelect(@wordpress/data)withViewportMatch(@wordpress/viewport)withSelectcorrectly receives a forwardedref.puretest suite to a single smoke test that verifies the HoC wraps a component and emits the deprecation warning.Why?
Now that Gutenberg is on React 19 (#61521),
React.memocovers every use case the custompureHoC was created for, andrefis a regular prop on function components. Promotingpurefrom a documentation-only deprecation to a runtime warning nudges remaining consumers toward the React-native primitives.Testing Instructions
CI checks are green
Use of AI Tools
Assisted by Claude.