-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Compose: Fully deprecate the 'pure' HoC #78674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,9 @@ import type { ComponentType } from 'react'; | |
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { createElement } from '@wordpress/element'; | ||
| import { createElement, memo } from '@wordpress/element'; | ||
| import { | ||
| createHigherOrderComponent, | ||
| pure, | ||
| useViewportMatch, | ||
| } from '@wordpress/compose'; | ||
|
|
||
|
|
@@ -78,7 +77,7 @@ const withViewportMatch = ( queries: ViewportQueries ) => { | |
| } ); | ||
| }; | ||
|
|
||
| return pure( WrappedWithViewport ); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curious why the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| return memo( WrappedWithViewport ); | ||
| }, | ||
| 'withViewportMatch' | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a drive-by change, we should give a name to the arrow function. We probably see a lot of
Anonymouscomponents in the React dev tools.