Skip to content

FEDX-2723: correctly ignore unused deps#152

Merged
btr-rmconsole-2[bot] merged 2 commits intomasterfrom
correctly_ignore_unused_deps_2
Mar 17, 2025
Merged

FEDX-2723: correctly ignore unused deps#152
btr-rmconsole-2[bot] merged 2 commits intomasterfrom
correctly_ignore_unused_deps_2

Conversation

@matthewnitschke-wk
Copy link
Copy Markdown
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Mar 14, 2025

FEDX-2723

Issue Status

Motivation

We backpatched this pr: #148, to v4.1.3, and want to apply the same change to master to prevent functional regressions with the latest release

Changes

Applies the same ignore specification, where anything ignored, is fully ignored

Testing/QA Instructions

  • Same QA should be sufficient

@matthewnitschke-wk matthewnitschke-wk changed the title correctly ignore unused deps FEDX-2723: correctly ignore unused deps Mar 14, 2025
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review March 14, 2025 20:58
@matthewnitschke-wk matthewnitschke-wk requested a review from a team as a code owner March 14, 2025 20:58
@matthewnitschke-wk
Copy link
Copy Markdown
Contributor Author

QA +1

  • CI does indeed pass, QAed on linked PR

🚀 @Workiva/release-management-p 🚢

Copy link
Copy Markdown
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-2 btr-rmconsole-2 bot merged commit e1e205e into master Mar 17, 2025
10 checks passed
@btr-rmconsole-2 btr-rmconsole-2 bot deleted the correctly_ignore_unused_deps_2 branch March 17, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants