Skip to content

FEDX-2723: correctly ignore unused deps #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btr-rmconsole-2 merged 2 commits into from
Mar 17, 2025
Merged

FEDX-2723: correctly ignore unused deps #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9abf23
correctly ignore unused deps
matthewnitschke-wk Mar 14, 2025
a67913d
fmt
matthewnitschke-wk Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions lib/src/dependency_validator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,15 @@ Future<bool> checkPackage({required String root}) async {

// Packages that are not used anywhere but are dependencies.
final unusedDependencies =
// Start with all explicitly declared dependencies
deps
.union(devDeps)
// Remove all deps that were used in Dart code somewhere in this package
.difference(packagesUsedInPublicFiles)
.difference(packagesUsedOutsidePublicDirs)
// Remove this package, since we know they're using our executable
..remove(dependencyValidatorPackageName);
// Start with all explicitly declared dependencies
deps
.union(devDeps)
// Remove all deps that were used in Dart code somewhere in this package
.difference(packagesUsedInPublicFiles)
.difference(packagesUsedOutsidePublicDirs)
// Remove this package, since we know they're using our executable
..remove(dependencyValidatorPackageName)
..removeAll(ignoredPackages);

final packageConfig = await findPackageConfig(Directory.current);
if (packageConfig == null) {
Expand Down Expand Up @@ -400,9 +401,6 @@ Future<bool> checkPackage({required String root}) async {
);
}

// Ignore known unused packages
unusedDependencies.removeAll(ignoredPackages);

if (unusedDependencies.isNotEmpty) {
log(
Level.WARNING,
Expand Down