Skip to content

refactor: Make token issuances type-safe#6621

Draft
mvadari wants to merge 33 commits intomvadari/rearch/accountfrom
mvadari/rearch/token
Draft

refactor: Make token issuances type-safe#6621
mvadari wants to merge 33 commits intomvadari/rearch/accountfrom
mvadari/rearch/token

Conversation

@mvadari
Copy link
Copy Markdown
Collaborator

@mvadari mvadari commented Mar 23, 2026

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 23, 2026
@mvadari mvadari force-pushed the mvadari/rearch/token branch from 18401a3 to b1537e9 Compare March 23, 2026 17:00
@mvadari mvadari force-pushed the mvadari/rearch/token branch from bacd9a6 to 3bc4609 Compare March 23, 2026 18:10
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.6%. Comparing base (ea3ca12) to head (dae0a53).

Files with missing lines Patch % Lines
src/libxrpl/protocol/Indexes.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           mvadari/rearch/account   #6621     +/-   ##
========================================================
- Coverage                    81.6%   81.6%   -0.0%     
========================================================
  Files                        1011    1011             
  Lines                       76090   76090             
  Branches                     7640    7640             
========================================================
- Hits                        62071   62070      -1     
- Misses                      14019   14020      +1     
Files with missing lines Coverage Δ
include/xrpl/protocol/Indexes.h 100.0% <ø> (ø)
src/libxrpl/protocol/Indexes.cpp 96.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions
Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant