Skip to content

refactor: Make token issuances type-safe #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mvadari wants to merge 33 commits into
base: mvadari/rearch/account
Choose a base branch
from
+13 −13
Draft

refactor: Make token issuances type-safe #6621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e9eb5e5
add WrappedSLEBase
mvadari Mar 16, 2026
1f73da4
First cut of WrappedAccountRoot
mvadari Mar 16, 2026
d9bf263
fix all the build issues
mvadari Mar 17, 2026
5fa9bb5
fix more build issues
mvadari Mar 17, 2026
ea1146d
fix remaining build issues
mvadari Mar 17, 2026
265decc
minor improvements
mvadari Mar 17, 2026
74b010a
split up read only and write
mvadari Mar 17, 2026
0cf42b1
Add insert/update/erase to WritableSLE
mvadari Mar 18, 2026
6fcda88
clean up comments
mvadari Mar 18, 2026
fa8de2b
change . to ->
mvadari Mar 21, 2026
45531b1
fix more AccountRoot stuff
mvadari Mar 21, 2026
f3a6d17
fix long tail issues
mvadari Mar 21, 2026
89a3a6c
more fixes
mvadari Mar 22, 2026
e68d74c
fix account_
mvadari Mar 22, 2026
ee370fe
fix issues
mvadari Mar 23, 2026
7056b43
WrappedSLEBase -> SLEBase
mvadari Mar 23, 2026
c9db124
add readme
mvadari Mar 23, 2026
8a1adc4
fix pre-commit issues
mvadari Mar 23, 2026
8e218a6
cleanup
mvadari Mar 23, 2026
3c5e878
establish architecture for creating a new object
mvadari Mar 23, 2026
14fbdd5
implement most of the token stuff
mvadari Mar 17, 2026
96d4a69
add some more helper functions
mvadari Mar 22, 2026
ad2c359
more usage of MPToken
mvadari Mar 22, 2026
7e62ecb
more usage of IOUToken
mvadari Mar 22, 2026
6afcf51
rename MPToken -> MPTokenIssuance
mvadari Mar 22, 2026
4e92ec2
fix issues
mvadari Mar 23, 2026
3b2dcef
fix more stuff
mvadari Mar 23, 2026
29bb596
fix pre-commit issues
mvadari Mar 23, 2026
9d67db1
fix rebase issues
mvadari Mar 23, 2026
733dd51
fix includes
mvadari Mar 23, 2026
d1dae53
fix clang-tidy
mvadari Mar 23, 2026
3bc4609
add makeNew functions
mvadari Mar 23, 2026
dae0a53
Merge branch 'mvadari/rearch/account' into mvadari/rearch/token
mvadari Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions include/xrpl/ledger/helpers/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ Both specializations share all domain read methods. Write methods on `WAccountRo

## Files in This Directory

| File | Description |
| ---------------------- | ---------------------------------------------------------------------------------------------------- |
| `SLEBase.h` | Template base class `SLEBase<ViewT>` and `ReadOnlySLE`/`WritableSLE` aliases |
| `AccountRootHelpers.h` | `AccountRoot<ViewT>` wrapper (`RAccountRoot`, `WAccountRoot`) and free functions for pseudo-accounts |
| `CredentialHelpers.h` | Free functions for Credential ledger entries |
| `DirectoryHelpers.h` | Free functions for directory traversal (`dirFirst`, `dirNext`, `forEachItem`, etc.) |
| `MPTokenHelpers.h` | Free functions for MPToken and MPTokenIssuance ledger entries |
| `OfferHelpers.h` | Free function `offerDelete` for removing Offer entries |
| `RippleStateHelpers.h` | Free functions for RippleState (trust line) entries: credit, freeze, issuance, authorization |
| `TokenHelpers.h` | Shared token helpers (freeze/auth checks used by both IOU and MPT paths) |
| `VaultHelpers.h` | Free functions for Vault ledger entries |
| File | Description |
| ---------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `SLEBase.h` | Template base class `SLEBase<ViewT>` and `ReadOnlySLE`/`WritableSLE` aliases |
| `AccountRootHelpers.h` | `AccountRoot<ViewT>` wrapper (`RAccountRoot`, `WAccountRoot`) and free functions for pseudo-accounts |
| `CredentialHelpers.h` | Free functions for Credential ledger entries |
| `DirectoryHelpers.h` | Free functions for directory traversal (`dirFirst`, `dirNext`, `forEachItem`, etc.) |
| `MPTokenHelpers.h` | Free functions for MPToken ledger entries and MPTokenIssuance<ViewT> wrapper (`RMPTokenIssuance`, `WMPTokenIssuance`) functions for MPTokenIssuance objects |
| `OfferHelpers.h` | Free function `offerDelete` for removing Offer entries |
| `RippleStateHelpers.h` | Free functions for RippleState (trust line) entries: credit, freeze, issuance, authorization |
| `TokenHelpers.h` | Shared token helpers (freeze/auth checks used by both IOU and MPT paths) |
| `VaultHelpers.h` | Free functions for Vault ledger entries |

## Migration Status

Expand Down
2 changes: 1 addition & 1 deletion include/xrpl/protocol/Indexes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ credential(uint256 const& key) noexcept
}

Keylet
mptIssuance(std::uint32_t seq, AccountID const& issuer) noexcept;
mptIssuance(std::uint32_t const seq, AccountID const& issuer) noexcept;

Keylet
mptIssuance(MPTID const& issuanceID) noexcept;
Expand Down
2 changes: 1 addition & 1 deletion src/libxrpl/protocol/Indexes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@
}

Keylet
mptIssuance(std::uint32_t seq, AccountID const& issuer) noexcept
mptIssuance(std::uint32_t const seq, AccountID const& issuer) noexcept

Check warning on line 517 in src/libxrpl/protocol/Indexes.cpp

View check run for this annotation

Codecov / codecov/patch

src/libxrpl/protocol/Indexes.cpp#L517 

Added line #L517 was not covered by tests
{
return mptIssuance(makeMptID(seq, issuer));
}
Expand Down
Loading