test: Improve test coverage for tecDIR_FULL error in xrpld#6862
Open
neti-soft-com wants to merge 4 commits intoXRPLF:developfrom
Open
test: Improve test coverage for tecDIR_FULL error in xrpld#6862neti-soft-com wants to merge 4 commits intoXRPLF:developfrom
neti-soft-com wants to merge 4 commits intoXRPLF:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6862 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 1010 1010
Lines 75982 76007 +25
Branches 7633 7632 -1
=======================================
+ Hits 61982 62008 +26
+ Misses 14000 13999 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The main goal of this PR is to improve test coverage for the
xrpldapplication.With the recent ability to simulate the
tecDIR_FULLerror, we can now comprehensively cover all cases where this error is returned. Consequently, this PR modifies production code solely to remove the now-obsoleteLCOV_EXCL_LINEcomments.Context of Change
This PR is enabled by the implementation of #5935.
Once completed, it will resolve issue #5969.
Type of Change
test:- The changes only affect unit tests.API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Test Plan
Verification is done by running the automated unit test suite.
Code coverage metrics will reflect the newly covered
tecDIR_FULLerror branches.