feat(i18n): Add Turkish translations for viomi.vacuum.v38#1726
Open
muminkoykiran wants to merge 3 commits into
Open
feat(i18n): Add Turkish translations for viomi.vacuum.v38#1726muminkoykiran wants to merge 3 commits into
muminkoykiran wants to merge 3 commits into
Conversation
Complete Turkish (tr) translation for the viomi.vacuum.v38 robot vacuum device, covering all 8 services (128 entities): - Fix service:002/003 swap (Battery and Robot Cleaner were reversed) - Add service:002 (Robot Cleaner): status values, fault codes, sweep types, actions - Add service:004 (proprietary): brush/filter/mop life sensors, suction/water/mop-route selects, cleaning stats, map count - Add service:005 (scheduling/DND): all scheduling and do-not-disturb properties - Add service:006 (spot/zone): point and zone cleaning controls - Add service:007 (map): map management actions and properties - Add service:008 (sound): voice pack properties and find-robot action Tested on Home Assistant 2026.5.x with xiaomi_home v0.4.7. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Turkish (tr) MIoT localization strings for the viomi-v38 vacuum device to provide more complete/structured labels (including value lists, actions, and events).
Changes:
- Replaces the prior
trtranslation block forviomi-v38with a significantly expanded set of service/property/action/event labels. - Adds many
valuelistentries for operational states, error codes, cleaning types, and related options. - Adjusts/extends naming for map, scheduling, and voice related capabilities.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+663
to
+693
| "service:008": "Ses", | ||
| "service:008:property:003": "Hedef Ses Paketi", | ||
| "service:008:property:004": "Mevcut Ses Paketi", | ||
| "service:008:action:002": "Robotu Bul (Ses)", | ||
| "service:004:action:010": "Kalibrasyon", | ||
| "service:004:property:024": "Cihaz Saat Dilimi", | ||
| "service:004:property:028": "Temizlik Haritası URL", | ||
| "service:004:property:032": "Mevcut Harita ID", | ||
| "service:005:property:001": "Zamanlama ID", | ||
| "service:005:property:002": "Zamanlama Aktif", | ||
| "service:005:property:003": "Zamanlama Günleri", | ||
| "service:005:property:004": "Zamanlama Saati", | ||
| "service:005:property:005": "Zamanlama Dakikası", | ||
| "service:005:property:006": "Tekrar Et", | ||
| "service:005:property:008": "Zamanlama Modu", | ||
| "service:005:property:009": "Zamanlama Emme Gücü", | ||
| "service:005:property:010": "Zamanlama Su Akış Düzeyi", | ||
| "service:005:property:011": "İkinci Geçiş", | ||
| "service:005:property:012": "Zamanlama Harita ID", | ||
| "service:005:property:013": "Oda Sayısı", | ||
| "service:005:property:014": "Oda Verileri", | ||
| "service:005:property:020": "Saat Dilimi Parametresi", | ||
| "service:005:property:022": "Zamanlama Verisi", | ||
| "service:007:property:005": "Dil Parametresi", | ||
| "service:007:property:006": "Oda Birleştirme ID'leri", | ||
| "service:007:property:007": "Hedef Oda ID", | ||
| "service:007:property:008": "Oda Bölme Koordinatları", | ||
| "service:007:property:009": "Oda Adı", | ||
| "service:007:action:001": "Haritayı Türüne Göre Yükle", | ||
| "service:007:action:002": "Haritayı ID'ye Göre Yükle", | ||
| "service:004:property:031": "Cihaz Dili" |
Contributor
Author
There was a problem hiding this comment.
Fixed in the latest commit — all 227 keys are now sorted by service → property/action/event → valuelist order.
Comment on lines
+537
to
+543
| "service:002:property:002:valuelist:013": "Çöp Haznesi Dolu", | ||
| "service:002:property:002:valuelist:014": "Çöp Haznesi Çıkarılmış", | ||
| "service:002:property:002:valuelist:015": "Çöp Haznesi Dolu ve Çıkarılmış", | ||
| "service:002:property:002:valuelist:016": "Sıkışma", | ||
| "service:002:property:002:valuelist:017": "Kaldırıldı", | ||
| "service:002:property:002:valuelist:018": "Çöp Haznesi Çıkarılmış", | ||
| "service:002:property:002:valuelist:020": "Hedefe Ulaşılamıyor", |
Contributor
Author
There was a problem hiding this comment.
Verified against the MIoT spec: both error codes 14 and 18 have identical descriptions (Garbage Out) in the upstream spec. The duplicate Turkish translation is intentional — it reflects the spec faithfully. No change needed.
Add translations for service 4-8 properties that were still showing internal/English names: map upload type valuelist, DND boolean values, download status, voice pack properties, room operation controls, new map state, cleaned area type, and misc sensor properties. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed file
`custom_components/xiaomi_home/miot/specs/multi_lang.json` — `urn:miot-spec-v2:device:vacuum:0000A006:viomi-v38` entry, `tr` language only
What was translated (227 keys)
Test plan
🤖 Generated with Claude Code