Remove superfluous HttpError: Not Found from error output#195
Draft
Remove superfluous HttpError: Not Found from error output#195
HttpError: Not Found from error output#195Conversation
Instead of logging a detailed error with core.error() and then re-throwing the raw HTTP error (which gets logged again by core.setFailed() in index.js), throw a new Error with the user-friendly message directly. This eliminates the duplicate/superfluous raw error output like "HttpError: Not Found". Fixes #125 Agent-Logs-Url: https://github.com/actions/configure-pages/sessions/ee6b7f39-cfc5-415b-b70c-826c2b8cfcfe Co-authored-by: yoannchaudet <14911070+yoannchaudet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix superfluous HttpError: Not Found message
Remove superfluous Apr 2, 2026
HttpError: Not Found from error output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Pages is not enabled (common with forks), users see a duplicate error — the helpful message from
core.error()followed by a rawHttpError: Not Foundfromcore.setFailed()re-catching the thrown error:The second line adds no information.
Changes
src/api-client.js: Replacecore.error(msg) + throw errorpattern withthrow new Error(msg)across all three error paths infindOrCreatePagesSite. The user-friendly message propagates tocore.setFailed()inindex.jsdirectly, eliminating the duplicate raw HTTP error output.src/api-client.test.js: Update error assertions to checkerror.messagecontent instead oferror.response.status, matching the newErrorobjects.