Skip to content

Remove superfluous HttpError: Not Found from error output #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −21
Draft

Remove superfluous HttpError: Not Found from error output #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a55b1f3
Initial plan
Copilot Apr 2, 2026
742261a
Fix superfluous HttpError: Not Found by throwing user-friendly errors
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36419,11 +36419,9 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
pageObject = await getPagesSite({ githubToken })
} catch (error) {
if (!enablement) {
core.error(
`Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action. Error: ${error.message}`,
convertErrorToAnnotationProperties(error)
throw new Error(
`Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action.`
)
throw error
}
core.warning(`Get Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
}
Expand All @@ -36433,8 +36431,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
try {
pageObject = await enablePagesSite({ githubToken })
} catch (error) {
core.error(`Create Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
throw error
throw new Error(`Create Pages site failed. Error: ${error.message}`)
}

// This somehow implies that the Pages site was already created but initially failed to be retrieved.
Expand All @@ -36443,8 +36440,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
try {
pageObject = await getPagesSite({ githubToken })
} catch (error) {
core.error(`Get Pages site still failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
throw error
throw new Error(`Get Pages site still failed. Error: ${error.message}`)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 4 additions & 8 deletions src/api-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
pageObject = await getPagesSite({ githubToken })
} catch (error) {
if (!enablement) {
core.error(
`Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action. Error: ${error.message}`,
convertErrorToAnnotationProperties(error)
throw new Error(
`Get Pages site failed. Please verify that the repository has Pages enabled and configured to build using GitHub Actions, or consider exploring the \`enablement\` parameter for this action.`
)
throw error
}
core.warning(`Get Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
}
Expand All @@ -57,8 +55,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
try {
pageObject = await enablePagesSite({ githubToken })
} catch (error) {
core.error(`Create Pages site failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
throw error
throw new Error(`Create Pages site failed. Error: ${error.message}`)
}

// This somehow implies that the Pages site was already created but initially failed to be retrieved.
Expand All @@ -67,8 +64,7 @@ async function findOrCreatePagesSite({ githubToken, enablement = true }) {
try {
pageObject = await getPagesSite({ githubToken })
} catch (error) {
core.error(`Get Pages site still failed. Error: ${error.message}`, convertErrorToAnnotationProperties(error))
throw error
throw new Error(`Get Pages site still failed. Error: ${error.message}`)
}
}
}
Expand Down
6 changes: 2 additions & 4 deletions src/api-client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ describe('apiClient', () => {
})
} catch (error) {
erred = true
// re-raised error
expect(error.response.status).toEqual(404)
expect(error.message).toContain('Get Pages site failed')
}
expect(erred).toBe(true)
expect(mockGetPages).toHaveBeenCalledTimes(1)
Expand All @@ -188,8 +187,7 @@ describe('apiClient', () => {
})
} catch (error) {
erred = true
// re-raised error
expect(error.response.status).toEqual(500)
expect(error.message).toContain('Create Pages site failed')
}
expect(erred).toBe(true)
expect(mockGetPages).toHaveBeenCalledTimes(1)
Expand Down