Revised strings and add zh-TW localization#266
Revised strings and add zh-TW localization#266petercpg wants to merge 1 commit intoactivescott:masterfrom
Conversation
…ity; add zh-TW l10n 1. String `File`: move post-string colon into string, and updated translation in all locale resource files 2. String `SameDirMassage`: replaced with `ShortcutHelperMissing`, English string was added into into all locale resource files except zh-TW 3. Add full zh-TW translation
|
Hi @petercpg, thanks for the PR. |
| this.lblFile.Name = "lblFile"; | ||
| this.lblFile.TabIndex = 1; | ||
| this.lblFile.Text = $"{Strings.File}:"; | ||
| this.lblFile.Text = $"{Strings.File}"; |
There was a problem hiding this comment.
I'd rather have the : be present in this one line, instead of adding it in any translation file.
Please add it back and amend the translation files.
There was a problem hiding this comment.
Hi @mega5800, not all languages uses the same set of puncture marks. For Trad Chinese, we use full-width ： (U+FF1A), instead of half-width ones (U+003A).
Concating strings, or adding more texts before or after strings are usually a bad idea either, as translators are lack of contexts (what is going to be injected in runtime) and causing localizability issues sometimes. See more in the next comment reply for SameDirMassage.
There was a problem hiding this comment.
I understand your point, but the difference between U+FF1A & U+003A is too small, and in my opinion is not worth changing the existing translations files.
@activescott, any thoughts on this?
There was a problem hiding this comment.
Colons may be just trivial, the key reason to change is to do proper i18n and respect locale styles and customs.
There are other puncture marks do look different from English, full stops, quote marks, and so on. Quick quote:
- French require extra space before and after all marks
- Greek use different symbol for colons
We should just let localizers to decide what is more appropriate in their locale/language.
and in my opinion is not worth changing the existing translations files.
This is replied in #266 (comment). I am just moving colons into these resource files based on their locale usage, not using full-width ones except zh-TW, so UI Views are not actually changed for String File.
| Strings.MissingFile, | ||
| MessageBoxButtons.OK, | ||
| MessageBoxIcon.Error); | ||
| string.Format(Strings.ShortcutHelperMissing, Path.GetFileNameWithoutExtension(shortcutHelperExe), "lessmsi-gui.exe"), |
There was a problem hiding this comment.
why is this change necessary?
There was a problem hiding this comment.
The rendered full sentence in zh-TW translation is 檔案 Path.GetFileNameWithoutExtension(shortcutHelperExe) 應該位於相同資料夾 lessmsi-gui.exe. but this does comply with Chinese grammar, and does not sound natural.
A more appropriate translation should be ShortcutHelperMissing as proposed in this PR, 「{0}」檔案應該與「{1}」位於相同資料夾。, so filenames are injected in strings as placeholders, and localizers can adjust sentence order, based on the grammar of their target language.
| </data> | ||
| <data name="File" xml:space="preserve"> | ||
| <value>Datei</value> | ||
| <value>Datei:</value> |
There was a problem hiding this comment.
Please revert this change for all the translation files.
I'd rather have one : at the corresponding code line, rather than adding it to any translation file.
There was a problem hiding this comment.
These colons are added based on reason in #266 (comment) colons are added based on usage in other strings, so translators of each locale do not have to submit changes again.
| <data name="ViewTableError" xml:space="preserve"> | ||
| <value>Tabelle kann nicht angezeigt werden</value> | ||
| </data> | ||
| <data name="ShortcutHelperMissing" xml:space="preserve"> |
There was a problem hiding this comment.
Adding English text to a translation file is a wrong thing to do.
I understand that you might not speak all these languages to provide a proper translation.
And again, why do we need this text in the app?
There was a problem hiding this comment.
ShortcutHelperMissing is added to all language resource files as new string is added to replace original SameDirMassage. I can remove if missing new-added strings can fall back to English and it does not break building or runtime though.
2 participants
File: move post-string colon into string, and updated translation in all locale resource filesSameDirMassage: replaced withShortcutHelperMissing, English string was added into into all locale resource files except zh-TW👍🎉 First off, thanks for taking the time to contribute! 🎉👍
Please fill out the following checklist:
If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!