Migrate lowest Python version to 3.10 - #775
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 85.72% 86.00% +0.27%
==========================================
Files 17 17
Lines 3215 3215
==========================================
+ Hits 2756 2765 +9
+ Misses 459 450 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| # Unzip the steps to titles and widgets. | ||
| self.titles, widgets = zip(*steps) | ||
| self.titles, widgets = zip(*steps, strict=True) |
There was a problem hiding this comment.
ruff complained: https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/
|
I don't think this is worth it, we'll never run on Python 3.10. I opened an alternative just now to remove the failing job #776. It's probably worth it to keep testing Python 3.9 a while longer in case we need to backport any fixes for 2.x release. |
In that case, let's set a minimal version of Python to 3.11 or 3.12. The only reason I opened this PR is because 3.9 is end of life, 3.10 is still not.
There is a branch for that, exactly for this kind of fixes: https://github.com/aiidalab/aiidalab-widgets-base/tree/support/2.5.x. We can keep running 3.9 there. |
I know, but typically you do the fix on master first and then backport. Backporting is much easier if you can simply cherry-pick the commit and it works as intended, without having to to worry about a compatibility with the Python version. (to be clear I am for making the minimum version 3.12, just a bit later, I don't see a rush to do that) |
|
Alright, fine, I will bring it up in a meeting so we can collectively decide whether we want to move away from 3.9. To not block the development, I am closing this PR and approving yours. |
No description provided.