Skip to content

Migrate lowest Python version to 3.10 - #775

Closed
yakutovicha wants to merge 3 commits into
masterfrom
migrate/python3_10
Closed

Migrate lowest Python version to 3.10#775
yakutovicha wants to merge 3 commits into
masterfrom
migrate/python3_10

Conversation

@yakutovicha

Copy link
Copy Markdown
Member

No description provided.

@yakutovicha yakutovicha changed the title Migrate lowest version to Python3.10 Migrate lowest Python version to 3.10 Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (9aa7a4b) to head (91cc2bd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   85.72%   86.00%   +0.27%     
==========================================
  Files          17       17              
  Lines        3215     3215              
==========================================
+ Hits         2756     2765       +9     
+ Misses        459      450       -9     
Flag Coverage Δ
python-3.10 86.00% <100.00%> (?)
python-3.12 85.81% <100.00%> (+0.09%) ⬆️
python-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


# Unzip the steps to titles and widgets.
self.titles, widgets = zip(*steps)
self.titles, widgets = zip(*steps, strict=True)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhollas

danielhollas commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I don't think this is worth it, we'll never run on Python 3.10. I opened an alternative just now to remove the failing job #776. It's probably worth it to keep testing Python 3.9 a while longer in case we need to backport any fixes for 2.x release.

@yakutovicha

Copy link
Copy Markdown
Member Author

I don't think this is worth it, we'll never run on Python 3.10.

In that case, let's set a minimal version of Python to 3.11 or 3.12. The only reason I opened this PR is because 3.9 is end of life, 3.10 is still not.

I opened an alternative just now to remove the failing job #776. It's probably worth it to keep testing Python 3.9 a while longer in case we need to backport any fixes for 2.x release.

There is a branch for that, exactly for this kind of fixes: https://github.com/aiidalab/aiidalab-widgets-base/tree/support/2.5.x. We can keep running 3.9 there.

@danielhollas

Copy link
Copy Markdown
Contributor

There is a branch for that, exactly for this kind of fixes: https://github.com/aiidalab/aiidalab-widgets-base/tree/support/2.5.x. We can keep running 3.9 there.

I know, but typically you do the fix on master first and then backport. Backporting is much easier if you can simply cherry-pick the commit and it works as intended, without having to to worry about a compatibility with the Python version.

(to be clear I am for making the minimum version 3.12, just a bit later, I don't see a rush to do that)

@yakutovicha

Copy link
Copy Markdown
Member Author

Alright, fine, I will bring it up in a meeting so we can collectively decide whether we want to move away from 3.9. To not block the development, I am closing this PR and approving yours.

@danielhollas
danielhollas deleted the migrate/python3_10 branch July 27, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants