Skip to content

Remove failing CI job - #776

Merged
danielhollas merged 1 commit into
masterfrom
drop-ci-job
Jul 27, 2026
Merged

Remove failing CI job#776
danielhollas merged 1 commit into
masterfrom
drop-ci-job

Conversation

@danielhollas

Copy link
Copy Markdown
Contributor

The Python 3.9 with resolution lowest-direct started failing for some unknown reason. Given the iminent migration to 3.12 we simply drop this particular job. I haven't removed testing on Python 3.9 entirely, since it might be useful in case we need to backport any fixes on 2.x release.

Comment thread .pre-commit-config.yaml
- id: ruff-format
exclude: ^docs/.*
- id: ruff
- id: ruff-check

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix, the ruff pre-commit id is deprecated

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (9aa7a4b) to head (1eac1c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   85.72%   85.90%   +0.18%     
==========================================
  Files          17       17              
  Lines        3215     3215              
==========================================
+ Hits         2756     2762       +6     
+ Misses        459      453       -6     
Flag Coverage Δ
python-3.12 85.90% <ø> (+0.18%) ⬆️
python-3.9 85.89% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edan-bainglass edan-bainglass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yakutovicha yakutovicha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't think this is a good way forward. 3.9 is EOL and we don't plan to use it moving forward. The 2.5.x support branch exists too.

@yakutovicha yakutovicha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in #775 (comment).

@danielhollas
danielhollas merged commit 62d5081 into master Jul 27, 2026
8 checks passed
@danielhollas
danielhollas deleted the drop-ci-job branch July 27, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants