Dependency upgrade/cleanup after dropping py3.9#7245
Draft
agoscinski wants to merge 3 commits intoaiidateam:drop-py3.9from
Draft
Dependency upgrade/cleanup after dropping py3.9#7245agoscinski wants to merge 3 commits intoaiidateam:drop-py3.9from
agoscinski wants to merge 3 commits intoaiidateam:drop-py3.9from
Conversation
agoscinski
force-pushed
the
py3.9-post-cleanup
branch
2 times, most recently
from
156e311 to
ab9c709
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## drop-py3.9 #7245 +/- ##
==============================================
+ Coverage 79.70% 79.70% +0.01%
==============================================
Files 565 565
Lines 43863 43859 -4
==============================================
- Hits 34957 34954 -3
+ Misses 8906 8905 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Consider also this #7240 (comment) |
Collaborator
Author
|
Consider #7240 (comment) |
In Python 3.10-3.11, `importlib.metadata.entry_points()` returns a `SelectableGroups` dict (iterating yields group name strings, not `EntryPoint` objects), unlike the `importlib_metadata` backport which always returned a flat `EntryPoints` sequence. Flatten the dict before sorting to fix `AttributeError: 'str' object has no attribute 'group'`.
agoscinski
force-pushed
the
py3.9-post-cleanup
branch
from
728a4c5 to
07373ba
Compare
agoscinski
changed the title
Collaborator
Author
|
Consider upgrading pytest_asyncio https://github.com/aiidateam/aiida-core/pull/7258/changes#r2889517642 |
Collaborator
Let's do that in a separate PR, last time I tried it I ran into some ugly issues. |
danielhollas
approved these changes
Mar 17, 2026
| except AttributeError: | ||
| # This type is not available for Python 3.9 and older | ||
| UnionType = None # type: ignore[assignment,misc] | ||
| UnionType = types.UnionType |
Collaborator
There was a problem hiding this comment.
You can just import the UnionType directly above as
from types import UnionType
| except AttributeError: | ||
| # This is the backport for Python 3.9 and older | ||
| from get_annotations import get_annotations # type: ignore[no-redef] | ||
| get_annotations = inspect.get_annotations |
Collaborator
There was a problem hiding this comment.
Same here, let's get rid of this alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing two dependencies that are not anymore needed since we dropped 3.9.
We could also replace
pytzwithzoneinfobut that affects the hash function because the binary representation is not the same. A database migration seems a bit overkill to drop one dependency.