Draft method motions - #230
Open
Ddedalus wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
You can see how the motions would work by placing a breakpoing somewhere in the async by looking at the debug log. Method numeration starts at 1. |
Owner
|
Will look into this later. |
aioutecism
self-requested a review
July 24, 2018 08:13
| private n: number; | ||
|
|
||
| constructor(args: { direction: Direction, n?: number }) { | ||
| args.n = args.n === undefined ? 1 : args.n; |
There was a problem hiding this comment.
Could be solved a bit cleaner with nullish coalescing, assuming you're using TS 3.7+.
args.n = args.n ?? 1;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a bit trickier. I've figured out a way of obtaining information on which methods are where right from the vscode (so the upside is it works for any language which end user has support for).
The problem is it involves an async call and I don't understand the rest of the code well enough to know where to put it. Once a file is loaded, the list is returned really quickly but is still a Thenable :/
It may be reasonable to put a callback when for example the first character of ]m is recognised.
Please have a look and tell if this code is of any use.