fix(source-facebook-marketing): apply top-level include_incrementality fallback to custom insight streams by devin-ai-integration[bot] · Pull Request #76116 · airbytehq/airbyte

devin-ai-integration · 2026-04-07T09:45:56Z

What

Resolves https://github.com/airbytehq/oncall/issues/11903:

https://github.com/airbytehq/oncall/issues/11903

When include_incrementality is enabled at the top-level config, it only applied to built-in insight streams — custom insight streams ignored the top-level value and only used their own per-insight setting (which defaults to False).

How

One-line fix in source.py:356: add or config.include_incrementality fallback, matching the existing pattern used on adjacent lines for insights_lookback_window and insights_job_timeout.

Version bumped from 5.2.4 → 5.2.5 (patch).

Review guide

source_facebook_marketing/source.py — the one-line fix (line 356)
unit_tests/test_source.py — parametrized test covering all 4 boolean combinations

Note: The or operator on booleans means a custom insight cannot explicitly disable incrementality when the top-level config enables it. This is consistent with how insights_lookback_window and insights_job_timeout already behave on the adjacent lines.

Human review checklist

Confirm or fallback semantics are acceptable (top-level True always wins over per-insight False)
Verify test assertion via action_attribution_windows is a valid proxy — include_incrementality is consumed in __init__ to append "incrementality" to the windows list but is not stored as a public attribute

User Impact

Users who enable include_incrementality at the top-level config will now see it correctly applied to custom insight streams, not just built-in ones.

Can this PR be safely reverted and rolled back?

YES 💚

Link to Devin session: https://app.devin.ai/sessions/4918e123cd5f49e1999bcf3f93fe415d

…y fallback to custom insight streams Co-Authored-By: bot_apk <apk@cognition.ai>

devin-ai-integration · 2026-04-07T09:45:58Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

Co-Authored-By: bot_apk <apk@cognition.ai>

github-actions · 2026-04-07T09:46:24Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

🛠️ Quick Fixes
- /format-fix - Fixes most formatting issues.
- /bump-version - Bumps connector versions, scraping changelog description from the PR title.
  - Bump types: patch (default), minor, major, major_rc, rc, promote.
  - The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
  - The promote type strips the RC suffix to finalize a release.
  - Example: /bump-version type=rc or /bump-version type=minor
- /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
❇️ AI Testing and Review (internal link: AI-SDLC Docs):
- /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
- /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
- /ai-review - AI-powered PR review for connector safety and quality gates.
🚀 Connector Releases:
- /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
☕️ JVM connectors:
- /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
  Example: /update-connector-cdk-version connector=destination-bigquery
🐍 Python connectors:
- /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
- /poe source example lock - Alias for /poe connector source-example lock.
- /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
- /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
⚙️ Admin commands:
- /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
  Example: /force-merge reason="CI is flaky, tests pass locally"

📚 Show Repo Guidance

Helpful Resources

Breaking Changes Guide - Breaking changes, migration guides, and upgrade deadlines
Developing Connectors Locally
Managing Connector Secrets
On-Demand Regression Tests
#connector-ci-issues
#connector-publish-updates
#connector-build-statuses

📝 Edit this welcome message.

github-actions · 2026-04-07T09:49:12Z

`source-facebook-marketing` Connector Test Results

369 tests 365 ✅ 13s ⏱️
2 suites 4 💤
2 files 0 ❌

Results for commit 8dd6a8f.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-07T09:50:39Z

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-hcm0efbh9-airbyte-growth.vercel.app

Built with commit 8dd6a8f.
This pull request is being automatically deployed with vercel-action

devin-ai-integration · 2026-04-07T11:35:05Z

↪️ Triggering /ai-prove-fix per Hands-Free AI Triage Project triage next step.
Reason: CI is green (35 passed, 0 failed), fix is ready for pre-release validation against affected connections.
Linked issue: https://github.com/airbytehq/oncall/issues/11903
Devin session

octavia-bot · 2026-04-07T11:35:40Z

🔍 AI Prove Fix session starting... Running readiness checks and testing against customer connections. View playbook

🔗 Session URL: https://app.devin.ai/sessions/ac90e1d513aa40d3818a5a0d8122fd14

✅ Devin AI session created successfully!

devin-ai-integration · 2026-04-07T11:36:50Z

🔍 Prove-Fix Validation: `source-facebook-marketing` v5.2.5

Outcome: Fix Verified — No Regressions Detected ✅

The fix correctly applies the include_incrementality fallback to custom insight streams.

Pre-flight Checks

✅ Viability: Fix addresses reported issue
✅ Safety: No suspicious patterns
✅ Breaking Change: None — additive behavior only
✅ Reversibility: Fully reversible via rollback to 5.2.4
✅ Version Bump: Patch 5.2.4 → 5.2.5

Regression Tests

Workflow Run — Comparison mode (target from PR vs control 5.2.4)

Verb	Result	Details
`SPEC`	✅	No difference
`CHECK`	✅	No difference
`DISCOVER`	✅	No difference
`READ`	⚠️	Both versions failed identically (expired GSM creds). No regression.

Unit Test Coverage

PR includes 4 parametrized tests covering all (config, insight) boolean combinations for include_incrementality — all pass.

Live Connection Tests

Not performed — not required. Connector is not on the forced OAuth list, fix is non-breaking and reversible, and regression tests + unit tests provide sufficient evidence.

Evidence Details

Fix Analysis: One-line change at source.py:356 follows the identical fallback pattern used on adjacent lines 353-354 for insights_lookback_window and insights_job_timeout.

READ ⚠️ Details: Both target (dev) and control (5.2.4) failed with exit code 1, identical message counts (254 LOG, 97 TRACE), 0 records. This indicates expired GSM integration test credentials or a transient Facebook API issue — unrelated to this PR.

Pre-release Image: airbyte/source-facebook-marketing:5.2.5-preview.8dd6a8f (publish workflow)

Recommendation

✅ Safe to merge. No regressions detected. Post-merge rollout will be monitored by standard automation.

Devin session

github-actions · 2026-04-07T11:41:01Z

Pre-release Connector Publish Started

Publishing pre-release build for connector source-facebook-marketing.
PR: #76116

Pre-release versions will be tagged as {version}-preview.8dd6a8f
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-facebook-marketing:5.2.5-preview.8dd6a8f

Docker Hub: https://hub.docker.com/layers/airbyte/source-facebook-marketing/5.2.5-preview.8dd6a8f

Registry JSON:

OSS Registry

Cloud Registry

octavia-bot · 2026-04-09T11:36:07Z

AI PR Review starting...

Reviewing PR for connector safety and quality.
View playbook

🔗 Session URL: https://app.devin.ai/sessions/414b2252a0e3438aaac3b5d146c6a302

✅ Devin AI session created successfully!

devin-ai-integration · 2026-04-09T11:36:24Z

↪️ Triggering /ai-review per Hands-Free AI Triage Project triage next step.

Reason: /ai-prove-fix validation completed successfully. Proceeding to AI review before merge.

https://github.com/airbytehq/oncall/issues/11903

Devin session

devin-ai-integration · 2026-04-09T11:37:51Z

AI PR Review Report

Review Action: NO ACTION (NOT ELIGIBLE)

Gate	Status
PR Hygiene	PASS
Code Hygiene	PASS
Test Coverage	PASS
Code Security	PASS
Per-Record Performance	PASS
Breaking Dependencies	PASS
Backwards Compatibility	PASS
Forwards Compatibility	PASS
Behavioral Changes	PASS
Out-of-Scope Changes	PASS
CI Checks	PASS
Live / E2E Tests	PASS

📋 PR Details & Eligibility

Connector & PR Info

Connector(s): source-facebook-marketing
PR: #76116
HEAD SHA: 8dd6a8fb2c2f8a8a22ecfc00ee16a6a2bbd48fe7
Session: https://app.devin.ai/sessions/414b2252a0e3438aaac3b5d146c6a302

Auto-Approve Eligibility

Eligible: No
Category: not-eligible
Reason: PR contains functional source code changes (source.py one-line fix) — not docs-only, additive spec, patch/minor deps, or comment/whitespace-only.

Review Action Details

NO ACTION (NOT ELIGIBLE) — All gates pass but the PR contains functional code changes and is not eligible for auto-approval. No PR review submitted. Human review required.

Note: This bot can approve PRs when all gates pass AND the PR is eligible for auto-approval (docs-only, additive spec changes, patch/minor dependency bumps, or comment/whitespace-only changes). PRs with other types of changes require human review even if all gates pass.

🔍 Gate Evaluation Details

Gate-by-Gate Analysis

Gate	Status	Enforced?	Details
PR Hygiene	PASS	Yes	Description present (>50 chars), changelog updated, no unresolved human comments
Code Hygiene	PASS	WARNING	Source file modified (`source.py`) AND test file modified (`test_source.py`)
Test Coverage	PASS	Yes	Bug fix with new parametrized test covering all 4 boolean combinations
Code Security	PASS	Yes	No security-sensitive file patterns or keywords in diff hunks
Per-Record Performance	PASS	WARNING	Change is in stream initialization, not per-record processing path
Breaking Dependencies	PASS	WARNING	No dependency files modified (only version bump in metadata/pyproject)
Backwards Compatibility	PASS	Blocks Auto-Approve	No spec changes, no stream removals, no schema changes. Version bump is patch only.
Forwards Compatibility	PASS	Blocks Auto-Approve	No state/cursor/pagination/transformation keywords in diff hunks
Behavioral Changes	PASS	Blocks Auto-Approve	No rate limit/retry/backoff/timeout/error handler keywords in diff hunks
Out-of-Scope Changes	PASS	Skip	All changes are within `airbyte-integrations/connectors/source-facebook-marketing/` and `docs/`
CI Checks	PASS	Yes	All core checks green: Lint ✅, Test (365 passed, 4 skipped) ✅, Format ✅, Changelog ✅
Live / E2E Tests	PASS	Yes	Pre-release validation via `/ai-prove-fix` — regression tests passed (SPEC ✅, CHECK ✅, DISCOVER ✅, READ ⚠️ identical failure in both versions)

PR Hygiene

PR Body Length (raw): ~1,420 characters
PR Body Length (after stripping): ~1,400 characters
PR Body Length (visible content): ~1,200 characters
PR Body Preview: ## What\n\nResolves https://github.com/airbytehq/oncall/issues/11903:\n- https://github.com/airbyte...
Docs Changelog: docs/integrations/sources/facebook-marketing.md updated with new version 5.2.5 entry ✅
Peer Feedback: No human reviewer comments found. All comments are from bot accounts ([bot] suffix).

Code Hygiene

Source Files Modified: source_facebook_marketing/source.py (1 line changed)
Test Files Modified: unit_tests/test_source.py (+28 lines, new parametrized test)
Coverage Evidence: Found — new test test_custom_insights_include_incrementality_fallback with 4 parametrized cases

Test Coverage

Behavioral Change Detected: Yes
Indicators Found: PR title contains fix; PR linked to issue https://github.com/airbytehq/oncall/issues/11903
Test Files Modified: unit_tests/test_source.py
New Test Content Found: Yes
Test Content Evidence: def test_custom_insights_include_incrementality_fallback(self, ...) with assert has_incrementality == expected_has_incrementality

Code Security

No changed files match security-sensitive path patterns
Diff hunks in metadata.yaml contain only dockerImageTag version change — no security keywords (allowedHosts, connectorBuildOptions, dockerRepository, authenticator, etc.)
Diff hunks in source.py contain only include_incrementality parameter change — no auth/credential keywords

Per-Record Performance

The change is at stream initialization time (constructing custom insight stream objects), not in the per-record processing path
No performance concerns

Breaking Dependencies

No dependency version changes (only connector version bump in metadata.yaml and pyproject.toml)
No build.gradle, requirements.txt, or library version changes

Backwards Compatibility

No spec file changes
No stream removals or renames
No schema changes
Patch version bump 5.2.4 → 5.2.5
The or fallback semantics mean top-level True wins over per-insight False — this is additive behavior, consistent with adjacent parameters

Forwards Compatibility

No state/cursor/pagination/transformation keywords in changed diff hunks
The change only affects how include_incrementality boolean is resolved during stream construction

Behavioral Changes

No rate limit, retry, backoff, timeout, sleep, error handler, or resource keywords in diff hunks
The only behavioral change is the or config.include_incrementality fallback, which is an intentional bug fix

Live / E2E Tests

Validation required: Yes — this is a bug fix (title contains fix, linked to oncall issue)
Evidence found: /ai-prove-fix validation completed successfully (Comment)
- Pre-release image published: airbyte/source-facebook-marketing:5.2.5-preview.8dd6a8f
- Regression tests: SPEC ✅, CHECK ✅, DISCOVER ✅, READ ⚠️ (both target and control failed identically with expired GSM creds — not a regression)
- Unit tests: All 4 parametrized cases pass
MCP verification: Unavailable (Cloud SQL Proxy not running). Fell back to CI check-run evidence.

📚 Evidence Consulted

Evidence

Changed files: 5 files
- airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
- airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml
- airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py
- airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_source.py
- docs/integrations/sources/facebook-marketing.md
CI checks: 36 passed, 9 skipped, 0 failed
- Lint source-facebook-marketing Connector ✅
- Test source-facebook-marketing Connector ✅ (369 tests, 365 passed, 4 skipped)
- Connector CI Checks Summary ✅
- Format Check ✅
- Check Changelog Updated ✅
- Build Airbyte Docs ✅
PR labels: connectors/source/facebook-marketing
PR description: Present, detailed with What/How/Review Guide/User Impact sections
Existing bot reviews: None
Pre-release validation: /ai-prove-fix completed — no regressions detected

Devin session

fix(source-facebook-marketing): apply top-level include_incrementalit…

a256461

…y fallback to custom insight streams Co-Authored-By: bot_apk <apk@cognition.ai>

fix: update changelog with PR number

8dd6a8f

Co-Authored-By: bot_apk <apk@cognition.ai>

Octavia Squidington III (octavia-squidington-iii) added the connectors/source/facebook-marketing label Apr 7, 2026

octavia-bot bot marked this pull request as ready for review April 9, 2026 11:36

Conversation

devin-ai-integration bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Review guide

Human review checklist

User Impact

Can this PR be safely reverted and rolled back?

Uh oh!

devin-ai-integration bot commented Apr 7, 2026

🤖 Devin AI Engineer

Uh oh!

github-actions bot commented Apr 7, 2026

👋 Greetings, Airbyte Team Member!

PR Slash Commands

Helpful Resources

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

source-facebook-marketing Connector Test Results

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot commented Apr 7, 2026

Uh oh!

octavia-bot bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Prove-Fix Validation: source-facebook-marketing v5.2.5

Pre-flight Checks

Regression Tests

Unit Test Coverage

Live Connection Tests

Recommendation

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

octavia-bot bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot commented Apr 9, 2026

Uh oh!

devin-ai-integration bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI PR Review Report

Connector & PR Info

Auto-Approve Eligibility

Review Action Details

Gate-by-Gate Analysis

PR Hygiene

Code Hygiene

Test Coverage

Code Security

Per-Record Performance

Breaking Dependencies

Backwards Compatibility

Forwards Compatibility

Behavioral Changes

Live / E2E Tests

Evidence

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration bot commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

`source-facebook-marketing` Connector Test Results

github-actions bot commented Apr 7, 2026 •

edited

Loading

octavia-bot bot commented Apr 7, 2026 •

edited

Loading

devin-ai-integration bot commented Apr 7, 2026 •

edited

Loading

🔍 Prove-Fix Validation: `source-facebook-marketing` v5.2.5

github-actions bot commented Apr 7, 2026 •

edited

Loading

octavia-bot bot commented Apr 9, 2026 •

edited

Loading

devin-ai-integration bot commented Apr 9, 2026 •

edited

Loading