Skip to content

fix(source-facebook-marketing): apply top-level include_incrementality fallback to custom insight streams #76116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(source-facebook-marketing): apply top-level include_incrementality fallback to custom insight streams #76116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a256461
fix(source-facebook-marketing): apply top-level include_incrementalit…
devin-ai-integration[bot] Apr 7, 2026
8dd6a8f
fix: update changelog with PR number
devin-ai-integration[bot] Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
dockerImageTag: 5.2.4
dockerImageTag: 5.2.5
dockerRepository: airbyte/source-facebook-marketing
documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
externalDocumentationUrls:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "5.2.4"
version = "5.2.5"
name = "source-facebook-marketing"
description = "Source implementation for Facebook Marketing."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down
2 changes: 1 addition & 1 deletion ...yte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def get_custom_insights_streams(self, api: API, config: ConnectorConfig) -> List
insights_lookback_window=insight.insights_lookback_window or config.insights_lookback_window,
insights_job_timeout=insight.insights_job_timeout or config.insights_job_timeout,
level=insight.level,
include_incrementality=insight.include_incrementality,
include_incrementality=insight.include_incrementality or config.include_incrementality,
)
streams.append(stream)
return streams
28 changes: 28 additions & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,34 @@ def test_get_custom_insights_streams_with_time_increment_period(self, api, confi
assert streams[0].time_increment_period == TimeIncrementPeriod.weekly
assert streams[0].time_increment == 7

@pytest.mark.parametrize(
"config_include_incrementality,insight_include_incrementality,expected_has_incrementality",
[
pytest.param(False, False, False, id="both_false"),
pytest.param(True, False, True, id="config_true_insight_false_falls_back"),
pytest.param(False, True, True, id="config_false_insight_true"),
pytest.param(True, True, True, id="both_true"),
],
)
def test_custom_insights_include_incrementality_fallback(
self, api, config, fb_marketing, config_include_incrementality, insight_include_incrementality, expected_has_incrementality
):
config["include_incrementality"] = config_include_incrementality
config["custom_insights"] = [
{
"name": "test_incrementality",
"fields": ["account_id"],
"breakdowns": [],
"action_breakdowns": ["action_type"],
"include_incrementality": insight_include_incrementality,
},
]
config = ConnectorConfig.parse_obj(config)
streams = fb_marketing.get_custom_insights_streams(api, config)
assert len(streams) == 1
has_incrementality = "incrementality" in streams[0].action_attribution_windows
assert has_incrementality == expected_has_incrementality

def test_get_custom_insights_action_breakdowns_allow_empty(self, api, config, fb_marketing):
config["custom_insights"] = [
{
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/facebook-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ Facebook’s Ads Insights API dynamically aggregates and filters metrics. Purcha

| Version | Date | Pull Request | Subject |
|:-----------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 5.2.5 | 2026-04-07 | [76116](https://github.com/airbytehq/airbyte/pull/76116) | Fix `include_incrementality` config option not applying to custom insight streams |
| 5.2.4 | 2026-04-01 | [75981](https://github.com/airbytehq/airbyte/pull/75981) | Fix ad_creatives_from_ads stream crash by catching AirbyteTracedException in creative detail fetching |
| 5.2.3 | 2026-03-24 | [75372](https://github.com/airbytehq/airbyte/pull/75372) | Fix `_collect_child_ids`: clamp `since <= until` after retention validation, add retry logic for transient `Job Failed` status, and apply `fields_exceptions` filtering to exclude problematic fields from API requests |
| 5.2.2 | 2026-03-17 | [75130](https://github.com/airbytehq/airbyte/pull/75130) | Extend upgrade deadline for version 5.0.0 breaking changes to 2026-04-10 |
Expand Down
Loading