Fix illegal attempts to connect to NodeChunks#3085
Draft
Fix illegal attempts to connect to NodeChunks#3085
NodeChunks#3085Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3085 +/- ##
========================================
Coverage 83.47% 83.47%
========================================
Files 81 81
Lines 10300 10300
========================================
Hits 8598 8598
Misses 1702 1702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses thread-safety and signal connection issues in the
meshroomapplication, primarily by ensuring that certain operations involving Qt objects are executed on the main thread. This helps prevent crashes and undefined behavior when interacting with QML and Qt signals from background threads.Qt Thread-Safety and Signal Handling Improvements:
clearSubmittedChunksis invoked on the main thread usingQMetaObject.invokeMethodwithQt.QueuedConnectioninmeshroom/core/taskManager.py, to safely createNodeChunkQObjects for QML connections.timesAvailablesignal to thecompareFilesTimesslot inmeshroom/ui/graph.pyto useQt.QueuedConnection, ensuring the slot is executed on the main thread.