Skip to content

Fix illegal attempts to connect to NodeChunks#3085

Draft
cbentejac wants to merge 2 commits intodevelopfrom
fix/qqmlengineIllegalAttempt
Draft

Fix illegal attempts to connect to NodeChunks#3085
cbentejac wants to merge 2 commits intodevelopfrom
fix/qqmlengineIllegalAttempt

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This pull request addresses thread-safety and signal connection issues in the meshroom application, primarily by ensuring that certain operations involving Qt objects are executed on the main thread. This helps prevent crashes and undefined behavior when interacting with QML and Qt signals from background threads.

Qt Thread-Safety and Signal Handling Improvements:

  • Ensured that clearSubmittedChunks is invoked on the main thread using QMetaObject.invokeMethod with Qt.QueuedConnection in meshroom/core/taskManager.py, to safely create NodeChunk QObjects for QML connections.
  • Changed the connection of the timesAvailable signal to the compareFilesTimes slot in meshroom/ui/graph.py to use Qt.QueuedConnection, ensuring the slot is executed on the main thread.

@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Apr 23, 2026
@cbentejac cbentejac self-assigned this Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.47%. Comparing base (b55440c) to head (62d3687).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3085   +/-   ##
========================================
  Coverage    83.47%   83.47%           
========================================
  Files           81       81           
  Lines        10300    10300           
========================================
  Hits          8598     8598           
  Misses        1702     1702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant