Skip to content

Fix illegal attempts to connect to NodeChunks #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cbentejac wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix illegal attempts to connect to NodeChunks #3085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff4b0b
[ui] graph: Use `Qt.QueuedConnection` for `timesAvailable` connection
cbentejac Apr 23, 2026
62d3687
[core] taskManager: Queue call to the `clearSubmittedChunk` slot
cbentejac Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions meshroom/core/taskManager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import traceback
import logging
from threading import Thread
from PySide6.QtCore import Qt, QThread, QEventLoop, QTimer
from PySide6.QtCore import Qt, QMetaObject, QThread, QEventLoop, QTimer
from enum import Enum
from meshroom.common import strtobool

Expand Down Expand Up @@ -139,7 +139,9 @@ def run(self):
except ValueError:
# Node already removed (for instance a global clear of _nodesToProcess)
pass
n.clearSubmittedChunks()
# clearSubmittedChunks may create NodeChunk QObjects; those must be
# created on the main thread so QML can safely connect to them.
QMetaObject.invokeMethod(n, "clearSubmittedChunks", Qt.QueuedConnection)
node.postprocess()

if stopAndRestart:
Expand Down
3 changes: 2 additions & 1 deletion meshroom/ui/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from collections import OrderedDict

from PySide6.QtCore import (
Qt,
Slot,
QJsonValue,
QObject,
Expand Down Expand Up @@ -150,7 +151,7 @@ def __init__(self, parent=None):
self.monitorableNodes = []
self.monitoredFiles = {} # Dict {filepath: node}
self._filesTimePoller = FilesModTimePollerThread(parent=self)
self._filesTimePoller.timesAvailable.connect(self.compareFilesTimes)
self._filesTimePoller.timesAvailable.connect(self.compareFilesTimes, Qt.QueuedConnection)
self._filesTimePoller.start()
self.setMonitored([])
self.filePollerRefreshChanged.connect(self._filesTimePoller.onFilePollerRefreshChanged)
Expand Down
Loading