Skip to content

Support ACP as an agent - #102

Merged
monatis merged 4 commits into
mainfrom
acp
Jul 30, 2026
Merged

Support ACP as an agent#102
monatis merged 4 commits into
mainfrom
acp

Conversation

@monatis

@monatis monatis commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully implements Agent Client Protocol (ACP) support, adding a new communication channel for the agent. The implementation is well-structured with proper separation of concerns across protocol types, bridge utilities, and channel integration.

Key additions reviewed:

  • Complete ACP protocol type definitions with JSON-RPC 2.0 support
  • Session management with lifecycle handling (new, prompt, cancel, close, delete, load, resume)
  • Bidirectional communication over stdio with proper async handling
  • Tool kind classification and content block parsing
  • Telemetry event forwarding (thoughts, tool calls, usage)
  • Integration with existing bus messaging architecture

The implementation follows Rust best practices with appropriate error handling, resource management, and concurrency patterns. No blocking issues found.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.


⚠️ This PR contains more than 30 files. Amazon Q is better at reviewing smaller PRs, and may miss issues in larger changesets.

@monatis
monatis merged commit 7018685 into main Jul 30, 2026
2 checks passed
@monatis
monatis deleted the acp branch July 30, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant