adf4377: add bleed delay & channel inversion, migrate eval project to STM32#3214
Open
skucukar wants to merge 4 commits into
Open
adf4377: add bleed delay & channel inversion, migrate eval project to STM32#3214skucukar wants to merge 4 commits into
skucukar wants to merge 4 commits into
Conversation
skucukar
requested review from
CiprianRegus,
RaduSabau1,
amiclaus,
buha,
cristina-suteu,
danmois,
dbogdan,
raezt,
ralucabozdog,
ranechita,
rbolboac,
rbudai98 and
stefpopa
as code owners
July 14, 2026 17:08
buha
reviewed
Jul 16, 2026
| $(PLATFORM_DRIVERS)/stm32_irq.c \ | ||
| $(PLATFORM_DRIVERS)/stm32_gpio_irq.c \ | ||
| $(PLATFORM_DRIVERS)/stm32_uart.c \ | ||
| $(PLATFORM_DRIVERS)/stm32_uart_stdio.c |
Contributor
There was a problem hiding this comment.
All .mk files needs to be removed as well.
I think you need to rebase off main branch which was updated today to migrate xilinx builds to the cmake/Kconfig build system.
buha
reviewed
Jul 16, 2026
| @@ -1,8 +1,8 @@ | |||
| PLATFORM = mbed | |||
| # PLATFORM = xilinx | |||
| PLATFORM = stm32 | |||
Contributor
There was a problem hiding this comment.
Makefile needs to be removed as well
buha
reviewed
Jul 16, 2026
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "mbed": { | |||
| "stm32": { | |||
Contributor
There was a problem hiding this comment.
builds.json needs to be removed, this build configuration is autodetected by the CI
buha
requested changes
Jul 16, 2026
buha
left a comment
buha
left a comment
Contributor
There was a problem hiding this comment.
rebase off fresh main and delete those files
Add adf4377_set_bleed_delay() and adf4377_get_bleed_delay() to program and read back the bleed delay in femtoseconds, with a helper that derives the delay per bleed-word step from the charge pump current and the PFD frequency. Rework the bleed word set/get to handle the enable and polarity bits and the correct 0x15/0x16 register layout, and store bleed_word as signed to preserve polarity. Add clock output and per-channel inversion set/get helpers. Make init non-fatal on the chip type, scratchpad and device ID checks by emitting warnings instead of aborting, drive the CE and CLK enable GPIOs high explicitly, and treat a VCO lock timeout during setup as a warning. Clamp the reference divider to a minimum of 1 and guard the PFD computation against a zero divider. Replace the deprecated <malloc.h> include with <stdlib.h>, fix the ADF4377_SINGLE_INSTR mask name, and return -ETIMEDOUT on lock failure. Assisted-by: Claude Opus 4.8 Signed-off-by: Sirac Kucukarabacioglu <sirac.kucukarabacioglu@analog.com>
Expose the new bleed delay and per-channel inversion controls through the IIO interface. Add a device-level "bleed_delay" attribute backed by adf4377_get/set_bleed_delay() and a per-channel "inv" attribute backed by adf4377_get/set_channel_inv(), with the matching enum IDs. Change the debug register read/write callbacks to take a void *dev and cast to struct adf4377_iio_dev internally, matching the iio debug callback signature. Mark the device-level attributes as IIO_SHARED_BY_ALL. Assisted-by: Claude Opus 4.8 Signed-off-by: Sirac Kucukarabacioglu <sirac.kucukarabacioglu@analog.com>
Document the bleed delay and channel inversion APIs and their IIO attributes in the ADF4377 driver README. Assisted-by: Claude Opus 4.8 Signed-off-by: Sirac Kucukarabacioglu <sirac.kucukarabacioglu@analog.com>
Project migrated from Mbed(EoL) to STM32 platform. Its tested and documentation updated. Kconfig added. Assisted-by: Claude Opus 4.8 Signed-off-by: Sirac Kucukarabacioglu sirac.kucukarabacioglu@analog.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Driver
IIO
Docs & Project
Testing
PR Type
PR Checklist