Introduce Align enum for text alignment in drawCell method - #40
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This pull request introduces type safety for text alignment in the drawCell method by replacing the string-based alignment parameter with a new Align backed enum. The PR also fixes spelling errors in two test method names, changing "Especial" to "Special" and correcting "Charaters" to "Characters".
Key Changes:
- Introduces a new
Alignbacked enum with four values: LEFT ('L'), CENTER ('C'), RIGHT ('R'), and JUSTIFIED ('J') - Updates the
drawCellmethod signature across AbstractBuilder, ZplBuilder, and PdfBuilder to use?Aligninstead ofstring - Fixes spelling errors in test method names
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Enums/Align.php | New backed string enum defining four alignment options (LEFT, CENTER, RIGHT, JUSTIFIED) |
| src/AbstractBuilder.php | Updates abstract drawCell method signature to use ?Align parameter and updates documentation |
| src/ZplBuilder.php | Implements nullable Align parameter with proper null-safety check before accessing the enum value |
| src/PdfBuilder.php | Implements nullable Align parameter with null coalescing operator |
| tests/ZplTest.php | Updates tests to use Align::CENTER enum and fixes spelling in test method names |
| README.md | Updates example code to use Align::CENTER enum instead of string 'C' |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@andersonls I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Add test case for drawCell with null align parameter --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: andersonls <1561038+andersonls@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.