Skip to content

Add test coverage for drawCell with null align parameter - #41

Merged
andersonls merged 2 commits into
improvement/align-enumfrom
copilot/sub-pr-40
Dec 15, 2025
Merged

Add test coverage for drawCell with null align parameter#41
andersonls merged 2 commits into
improvement/align-enumfrom
copilot/sub-pr-40

Conversation

Copilot AI commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

The existing tests only covered drawCell when an Align enum value was explicitly provided, leaving the default null case untested.

Changes

  • Added drawCellWithNullAlign() test that verifies the method correctly omits the ^FB alignment command when no alignment is specified
// Before: only tested with explicit alignment
$this->driver->drawCell(100, 10, 'Hello World', true, true, Align::CENTER);
// Output includes: ^FB90,7.5,0,C

// Now also tested: default null alignment
$this->driver->drawCell(100, 10, 'Hello World', true, true);
// Output correctly omits ^FB command

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: andersonls <1561038+andersonls@users.noreply.github.com>

Copilot AI commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/laravel/pint/zipball/69dcca060ecb15e4b564af63d1f642c81a241d6f
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/xROGwD /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/xROGwD /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpstan/phpstan/zipball/d2772ff4d9f1adb45e1935847b65a99a0cd15ca9
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/xROGwD /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/e1cd261f5ea34e8568b3fc827919410292d1ca69
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/cea2f459bb5d3d0a63bce71ddda57903d7150e53
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/sebastianbergmann/phpunit/zipball/98d145bf728b1d45b9ca56253b3e63268b082823
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/xROGwD /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/ee84e0473412ee0a6c381fbabd618b31955f3c7e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/04f923c375c0430774f283e53340c374c498a562
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/xROGwD /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/225ee32d2b812505e0a9bbe0faaf88c7b0c9ebd3
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)
  • https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/zfb5gt /usr/bin/composer update --prefer-dist --no-suggest gmann-complexitygit (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on Align enum implementation Add test coverage for drawCell with null align parameter Dec 14, 2025
Copilot AI requested a review from andersonls December 14, 2025 22:22
@andersonls
andersonls marked this pull request as ready for review December 15, 2025 21:55
@andersonls
andersonls merged commit 2098ae5 into improvement/align-enum Dec 15, 2025
@andersonls
andersonls deleted the copilot/sub-pr-40 branch December 15, 2025 21:55
andersonls added a commit that referenced this pull request Dec 15, 2025
* Introduce Align enum for text alignment in drawCell method

* Add test coverage for drawCell with null align parameter (#41)

* Add test case for drawCell with null align parameter

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: andersonls <1561038+andersonls@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants